Home Original page

Special-case raw ref op for diverging check in HIR typeck by compiler-errors · Pull Request #129371 · rust-lang/rust

@compiler-errors

@rustbot rustbot added S-waiting-on-review

Status: Awaiting review from the assignee but also interested parties.

T-compiler

Relevant to the compiler team, which will review and decide on the PR/issue.

labels

Aug 21, 2024

compiler-errors

bors added a commit to rust-lang-ci/rust that referenced this pull request

Aug 22, 2024 
…verge-but-more, r=<try>

[EXPERIMENT] Do not consider match/let/raw-ref of deref that evalautes to ! to diverge

This is the more involved version of rust-lang#129371. It doesn't fully fix rust-lang#117288, since we still need to fix the fact that never type fallback can cause an unintended load via the `NeverToAny` coercion. But I did want to probe crater to see if anyone relies on this behavior currently, since that's almost certainly UB.

r? `@ghost`

RalfJung

RalfJung

bors added a commit to rust-lang-ci/rust that referenced this pull request

Aug 22, 2024 
…verge-but-more, r=<try>

[EXPERIMENT] Do not consider match/let/raw-ref of deref that evalautes to ! to diverge

This is the more involved version of rust-lang#129371. It's pretty ugly rn.

r? `@ghost`

bors added a commit to rust-lang-ci/rust that referenced this pull request

Aug 22, 2024 
…verge-but-more, r=<try>

[EXPERIMENT] Do not consider match/let/raw-ref of deref that evalautes to ! to diverge

This is the more involved version of rust-lang#129371. It's pretty ugly rn.

r? `@ghost`

davidtwco