Use -0.0 in `intrinsics::simd::reduce_add_unordered` by workingjubilee · Pull Request #130325

Use -0.0 in `intrinsics::simd::reduce_add_unordered` by workingjubilee · Pull Request #130325 · rust-lang/rust

added S-waiting-on-review

Status: Awaiting review from the assignee but also interested parties.

T-compiler

Relevant to the compiler team, which will review and decide on the PR/issue.

labels

Sep 13, 2024

bors added a commit to rust-lang-ci/rust that referenced this pull request

Sep 13, 2024

…, r=<try>

Use -0.0 in `intrinsics::simd::reduce_add_unordered`

-0.0 is the actual neutral additive float, not +0.0, and this matters to codegen.

try-job: aarch64-gnu

bors added S-waiting-on-author

Status: This is awaiting some action (such as code changes or more information) from the author.

and removed S-waiting-on-review

Status: Awaiting review from the assignee but also interested parties.

labels

Sep 13, 2024

bors added a commit to rust-lang-ci/rust that referenced this pull request

Sep 13, 2024

…, r=<try>

Use -0.0 in `intrinsics::simd::reduce_add_unordered`

-0.0 is the actual neutral additive float, not +0.0, and this matters to codegen.

try-job: aarch64-gnu

bors added a commit to rust-lang-ci/rust that referenced this pull request

Sep 13, 2024

…, r=<try>

Use -0.0 in `intrinsics::simd::reduce_add_unordered`

-0.0 is the actual neutral additive float, not +0.0, and this matters to codegen.

try-job: aarch64-gnu

bors added a commit to rust-lang-ci/rust that referenced this pull request

Sep 14, 2024

…, r=<try>

Use -0.0 in `intrinsics::simd::reduce_add_unordered`

-0.0 is the actual neutral additive float, not +0.0, and this matters to codegen.

try-job: aarch64-gnu

matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request

Sep 15, 2024

…ux, r=RalfJung,jieyouxu

Use -0.0 in `intrinsics::simd::reduce_add_unordered`

-0.0 is the actual neutral additive float, not +0.0, and this matters to codegen.

try-job: aarch64-gnu

workingjubilee added a commit to workingjubilee/rustc that referenced this pull request

Sep 15, 2024

…ux, r=RalfJung,jieyouxu

Use -0.0 in `intrinsics::simd::reduce_add_unordered`

-0.0 is the actual neutral additive float, not +0.0, and this matters to codegen.

try-job: aarch64-gnu

workingjubilee added a commit to workingjubilee/rustc that referenced this pull request

Sep 15, 2024

…ux, r=RalfJung,jieyouxu

Use -0.0 in `intrinsics::simd::reduce_add_unordered`

-0.0 is the actual neutral additive float, not +0.0, and this matters to codegen.

try-job: aarch64-gnu

bors added a commit to rust-lang-ci/rust that referenced this pull request

Sep 15, 2024

…, r=RalfJung,jieyouxu

Use -0.0 in `intrinsics::simd::reduce_add_unordered`

-0.0 is the actual neutral additive float, not +0.0, and this matters to codegen.

try-job: aarch64-gnu

bors added a commit to rust-lang-ci/rust that referenced this pull request

Sep 15, 2024

…kingjubilee

Rollup of 3 pull requests

Successful merges:

 - rust-lang#130295 (Fix target-cpu fpu features on Armv8-R.)
 - rust-lang#130325 (Use -0.0 in `intrinsics::simd::reduce_add_unordered`)
 - rust-lang#130371 (Correctly account for niche-optimized tags in rustc_transmute)

r? `@ghost`
`@rustbot` modify labels: rollup

bors added S-waiting-on-author

Status: This is awaiting some action (such as code changes or more information) from the author.

and removed S-waiting-on-bors

Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

labels

Sep 15, 2024

-0.0 is the actual neutral additive float, not +0.0, and this matters to codegen.

bors added S-waiting-on-bors

Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

and removed S-waiting-on-author

Status: This is awaiting some action (such as code changes or more information) from the author.

labels

Sep 16, 2024

bors added a commit to rust-lang-ci/rust that referenced this pull request

Sep 16, 2024

…kingjubilee

Rollup of 5 pull requests

Successful merges:

 - rust-lang#127879 (Document futility of printing temporary pointers)
 - rust-lang#130325 (Use -0.0 in `intrinsics::simd::reduce_add_unordered`)
 - rust-lang#130336 (simplify `Build::update_existing_submodule`)
 - rust-lang#130398 (Add system libs for LLVM when cross compiling for Windows)
 - rust-lang#130420 (Register tool docs for `src/tools/build_helper`)

r? `@ghost`
`@rustbot` modify labels: rollup

rust-timer added a commit to rust-lang-ci/rust that referenced this pull request

Sep 16, 2024

Rollup merge of rust-lang#130325 - workingjubilee:plus-minus-zero-redux, r=RalfJung,jieyouxu

Use -0.0 in `intrinsics::simd::reduce_add_unordered`

-0.0 is the actual neutral additive float, not +0.0, and this matters to codegen.

try-job: aarch64-gnu

matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request

Sep 16, 2024

…dered_test, r=RalfJung

Ignore reduce-fadd-unordered on SGX platform

rust-lang#130325 added the `tests/assembly/simd/reduce-fadd-unordered.rs` test. Unfortunately, the use of `CHECK: ret` makes that this test is not compatible with LVI mitigations applied for the SGX target. This PR makes sure this test is ignored for the SGX target, until a nicer solution is available.

rust-timer added a commit to rust-lang-ci/rust that referenced this pull request

Sep 16, 2024

Rollup merge of rust-lang#130436 - fortanix:raoul/fix_reduce_add_unordered_test, r=RalfJung

Ignore reduce-fadd-unordered on SGX platform

rust-lang#130325 added the `tests/assembly/simd/reduce-fadd-unordered.rs` test. Unfortunately, the use of `CHECK: ret` makes that this test is not compatible with LVI mitigations applied for the SGX target. This PR makes sure this test is ignored for the SGX target, until a nicer solution is available.