validate `--skip` and `--exclude` paths by onur-ozkan · Pull Request #134209 · rust-lang/rust

@rustbot rustbot added S-waiting-on-review

Status: Awaiting review from the assignee but also interested parties.

T-bootstrap

Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)

labels

Dec 12, 2024

jieyouxu

jieyouxu

ChrisDenton

jieyouxu

@bors bors added S-waiting-on-bors

Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

and removed S-waiting-on-review

Status: Awaiting review from the assignee but also interested parties.

labels

Dec 12, 2024

matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request

Dec 12, 2024
…youxu

validate `--skip` and `--exclude` paths

Fixes rust-lang#134198

cc `@ChrisDenton`

bors added a commit to rust-lang-ci/rust that referenced this pull request

Dec 13, 2024
…iaskrgr

Rollup of 7 pull requests

Successful merges:

 - rust-lang#130060 (Autodiff Upstreaming - rustc_codegen_llvm changes)
 - rust-lang#132038 (Add lint rule for `#[deprecated]` on re-exports)
 - rust-lang#133937 (Keep track of parse errors in `mod`s and don't emit resolve errors for paths involving them)
 - rust-lang#133942 (Clarify how to use `black_box()`)
 - rust-lang#134081 (Try to evaluate constants in legacy mangling)
 - rust-lang#134192 (Remove `Lexer`'s dependency on `Parser`.)
 - rust-lang#134209 (validate `--skip` and `--exclude` paths)

Failed merges:

 - rust-lang#133099 (forbid toggling x87 and fpregs on hard-float targets)

r? `@ghost`
`@rustbot` modify labels: rollup

compiler-errors added a commit to compiler-errors/rust that referenced this pull request

Dec 13, 2024
…youxu

validate `--skip` and `--exclude` paths

Fixes rust-lang#134198

cc ``@ChrisDenton``

bors added a commit to rust-lang-ci/rust that referenced this pull request

Dec 13, 2024

@bors bors added S-waiting-on-author

Status: This is awaiting some action (such as code changes or more information) from the author.

and removed S-waiting-on-bors

Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

labels

Dec 13, 2024

@rustbot rustbot added S-waiting-on-review

Status: Awaiting review from the assignee but also interested parties.

and removed S-waiting-on-author

Status: This is awaiting some action (such as code changes or more information) from the author.

labels

Dec 13, 2024

@bors bors added S-waiting-on-bors

Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

and removed S-waiting-on-review

Status: Awaiting review from the assignee but also interested parties.

labels

Dec 13, 2024

@bors bors added S-waiting-on-author

Status: This is awaiting some action (such as code changes or more information) from the author.

and removed S-waiting-on-bors

Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

labels

Dec 13, 2024

jieyouxu

@bors bors added S-waiting-on-bors

Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

and removed S-waiting-on-author

Status: This is awaiting some action (such as code changes or more information) from the author.

labels

Dec 13, 2024

matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request

Dec 13, 2024
…youxu

validate `--skip` and `--exclude` paths

Fixes rust-lang#134198

cc `@ChrisDenton`

This was referenced

Dec 13, 2024

matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request

Dec 14, 2024
…youxu

validate `--skip` and `--exclude` paths

Fixes rust-lang#134198

cc ```@ChrisDenton```

bors added a commit to rust-lang-ci/rust that referenced this pull request

Dec 14, 2024
…iaskrgr

Rollup of 8 pull requests

Successful merges:

 - rust-lang#134181 (Tweak multispan rendering to reduce output length)
 - rust-lang#134209 (validate `--skip` and `--exclude` paths)
 - rust-lang#134231 (rustdoc-search: fix mismatched path when parent re-exported twice)
 - rust-lang#134236 (crashes: more tests v2)
 - rust-lang#134240 (Only dist `llvm-objcopy` if llvm tools are enabled)
 - rust-lang#134244 (rustc_borrowck: Stop suggesting the invalid syntax `&mut raw const`)
 - rust-lang#134251 (A bunch of cleanups (part 2))
 - rust-lang#134256 (Use a more precise span in placeholder_type_error_diag)

r? `@ghost`
`@rustbot` modify labels: rollup

rust-timer added a commit to rust-lang-ci/rust that referenced this pull request

Dec 14, 2024

jieyouxu added a commit to jieyouxu/rust that referenced this pull request

Dec 28, 2024
…s, r=jieyouxu"

Unfortunately, the preset logic is not quite right because `Step`s are
allowed to register arbitrary *aliases* (e.g. `library/test` is aliases
to `test`), which means that we incorrectly warn on

```
./x test test
```

even though this alias is indeed a known and handled filter.

A proper fix will need to do something like "collect all eligible
`Step`s then check `should_run(exclude)`" in order to determine if the
exclude filter will trigger for the steps. (Courtesy of jyn pointing
this out.)

This reverts commit 6cf13b0, reversing
changes made to 2846699.

jieyouxu added a commit to jieyouxu/rust that referenced this pull request

Dec 28, 2024
…s, r=jieyouxu"

Unfortunately, the preset logic is not quite right because `Step`s are
allowed to register arbitrary *aliases* (e.g. `library/test` is aliases
to `test`), which means that we incorrectly warn on

```
./x test --exclude test
```

producing

```
WARNING: '/home/joe/repos/rust/test' does not exist.
```

even though this alias (`test`) is indeed a known and handled
`--exclude` filter.

A proper fix will need to do something like "collect all eligible
`Step`s then check `should_run(exclude)`" in order to determine if the
exclude filter will trigger for the steps. (Courtesy of jyn pointing
this out.)

This reverts commit 6cf13b0, reversing
changes made to 2846699.

jieyouxu added a commit to jieyouxu/rust that referenced this pull request

Dec 28, 2024
…s, r=jieyouxu"

Unfortunately, the present logic is not quite right because `Step`s are
allowed to register arbitrary *aliases* (e.g. `library/test` is aliases
to `test`), which means that we incorrectly warn on

```
./x test --exclude test
```

producing

```
WARNING: '/home/joe/repos/rust/test' does not exist.
```

even though this alias (`test`) is indeed a known and handled
`--exclude` filter.

A proper fix will need to do something like "collect all eligible
`Step`s then check `should_run(exclude)`" in order to determine if the
exclude filter will trigger for the steps. (Courtesy of jyn pointing
this out.)

This reverts commit 6cf13b0, reversing
changes made to 2846699.