Home Original page

Advent of `tests/ui` (misc cleanups and improvements) [4/N] by jieyouxu · Pull Request #140036 · rust-lang/rust

@rustbot rustbot added S-waiting-on-review

Status: Awaiting review from the assignee but also interested parties.

T-compiler

Relevant to the compiler team, which will review and decide on the PR/issue.

labels

Apr 19, 2025

jieyouxu

@rustbot rustbot added the S-waiting-on-author

Status: This is awaiting some action (such as code changes or more information) from the author.

label

Apr 19, 2025

jieyouxu

- Reworked the test as a *centralized* version of checking that certain
  targets correctly require `-C target-cpu` being specified.
- Document test intention.
- Move `amdgpu-require-explicit-cpu.rs` under new dir
  `tests/ui/target-cpu/`
  - No other ui subdir really fits this "requires `-Ctarget-cpu`" check.
- `tests/ui/augmented-assignment-feature-gate-cross.rs`:
  - This was *originally* to feature-gate overloaded OpAssign
    cross-crate, but now let's keep it as a smoke test.
  - Renamed as `augmented-assignment-cross-crate.rs`.
  - Relocated under `tests/ui/binop/`.
-  `tests/ui/augmented-assignments.rs`:
  - Documented test intent.
  - Moved under `tests/ui/borrowck/`.
- `tests/ui/augmented-assignment-rpass.rs`:
  - Renamed to drop the `-rpass` suffix, since this was leftover from
    when `run-pass` test suite was a thing.
  - Moved under `tests/ui/binop/`.
- Reformat the test.
- Document test intention.
- Move test under `tests/ui/inference/`.

@rustbot rustbot added S-waiting-on-review

Status: Awaiting review from the assignee but also interested parties.

and removed S-waiting-on-author

Status: This is awaiting some action (such as code changes or more information) from the author.

labels

Apr 19, 2025

compiler-errors

@bors bors added S-waiting-on-bors

Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

and removed S-waiting-on-review

Status: Awaiting review from the assignee but also interested parties.

labels

Apr 20, 2025

jhpratt added a commit to jhpratt/rust that referenced this pull request

Apr 21, 2025 
…errors

Advent of `tests/ui` (misc cleanups and improvements) [4/N]

Some `tests/ui/` housekeeping, to trim down number of tests directly under `tests/ui/`. Part of rust-lang#133895.

### Review advice

- Best reviewed commit-by-commit.
- I can squash commits before merge, commits are separate to make it easier to review.

bors added a commit to rust-lang-ci/rust that referenced this pull request

Apr 21, 2025

bors added a commit to rust-lang-ci/rust that referenced this pull request

Apr 21, 2025

bors added a commit to rust-lang-ci/rust that referenced this pull request

Apr 21, 2025

jieyouxu added a commit to jieyouxu/rust that referenced this pull request

Apr 21, 2025 
…errors

Advent of `tests/ui` (misc cleanups and improvements) [4/N]

Some `tests/ui/` housekeeping, to trim down number of tests directly under `tests/ui/`. Part of rust-lang#133895.

### Review advice

- Best reviewed commit-by-commit.
- I can squash commits before merge, commits are separate to make it easier to review.

bors added a commit to rust-lang-ci/rust that referenced this pull request

Apr 21, 2025

bors added a commit to rust-lang-ci/rust that referenced this pull request

Apr 21, 2025

rust-timer added a commit to rust-lang-ci/rust that referenced this pull request

Apr 21, 2025 
Rollup merge of rust-lang#140036 - jieyouxu:ui-cleanup-4, r=compiler-errors

Advent of `tests/ui` (misc cleanups and improvements) [4/N]

Some `tests/ui/` housekeeping, to trim down number of tests directly under `tests/ui/`. Part of rust-lang#133895.

### Review advice

- Best reviewed commit-by-commit.
- I can squash commits before merge, commits are separate to make it easier to review.

github-actions bot pushed a commit to model-checking/verify-rust-std that referenced this pull request

Apr 23, 2025