Use select in projection lookup in `report_projection_error` by compiler-errors · Pull Request #140519 · rust-lang/rust
marked this pull request as ready for review
rustbot
added
S-waiting-on-review
labels
Apr 30, 2025
bors
added
S-waiting-on-bors
and removed S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.labels
May 1, 2025VlaDexa added a commit to VlaDexa/rust that referenced this pull request
May 2, 2025…son, r=oli-obk Use select in projection lookup in `report_projection_error` Using `for_each_relevant_impl` doesn't actually select the correct impl; we can use `select` here to actually get the correct impl with certainty. Follow-up to rust-lang#140278. r? oli-obk
bors added a commit to rust-lang-ci/rust that referenced this pull request
May 2, 2025…iaskrgr Rollup of 9 pull requests Successful merges: - rust-lang#140485 (Optimize the codegen for `Span::from_expansion`) - rust-lang#140509 (transmutability: merge contiguous runs with a common destination) - rust-lang#140519 (Use select in projection lookup in `report_projection_error`) - rust-lang#140521 (interpret: better error message for out-of-bounds pointer arithmetic and accesses) - rust-lang#140536 (Rename `*Guard::try_map` to `filter_map`.) - rust-lang#140550 (Stabilize `select_unpredictable`) - rust-lang#140563 (extend the list of registered dylibs on `test::prepare_cargo_test`) - rust-lang#140572 (Add useful comments on `ExprKind::If` variants.) - rust-lang#140574 (Add regression test for 133065) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request
May 3, 2025Rollup merge of rust-lang#140519 - compiler-errors:name-based-comparison, r=oli-obk Use select in projection lookup in `report_projection_error` Using `for_each_relevant_impl` doesn't actually select the correct impl; we can use `select` here to actually get the correct impl with certainty. Follow-up to rust-lang#140278. r? oli-obk
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request
May 22, 2025…lver, r=lcnr Don't allow `poly_select` in new solver I added a `poly_select` call in rust-lang#140519, but this causes an ICE since the new solver doesn't properly handle the "instantiate binder -> recanonicalize" step in the proof tree visitor. While we could fix the select visitor to look at the next step in proof tree, it's not really necessary. Instead, let's enforce that all callees call the non-higher-ranked `select` function in the new solver. Fixes rust-lang#141322 r? lcnr
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request
May 22, 2025Rollup merge of rust-lang#141390 - compiler-errors:poly-select-new-solver, r=lcnr Don't allow `poly_select` in new solver I added a `poly_select` call in rust-lang#140519, but this causes an ICE since the new solver doesn't properly handle the "instantiate binder -> recanonicalize" step in the proof tree visitor. While we could fix the select visitor to look at the next step in proof tree, it's not really necessary. Instead, let's enforce that all callees call the non-higher-ranked `select` function in the new solver. Fixes rust-lang#141322 r? lcnr
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters