`impl PartialEq<{str,String}> for {Path,PathBuf}` by Kixunil · Pull Request #140956 · rust-lang/rust

@rustbot rustbot added S-waiting-on-review

Status: Awaiting review from the assignee but also interested parties.

T-libs

Relevant to the library team, which will review and decide on the PR/issue.

labels

May 13, 2025

@Kixunil

Comparison of paths and strings is expected to be possible and needed
e.g. in tests. This change adds the impls os `PartialEq` between strings
and paths, both owned and unsized, in both directions.

ACP: rust-lang/libs-team#151

@rustbot rustbot added the T-libs-api

Relevant to the library API team, which will review and decide on the PR/issue.

label

May 15, 2025

bors added a commit to rust-lang-ci/rust that referenced this pull request

May 18, 2025
… r=<try>

`impl PartialEq<{str,String}> for {Path,PathBuf}`

This is a revival of rust-lang#105877

Comparison of paths and strings is expected to be possible and needed e.g. in tests. This change adds the impls os `PartialEq` between strings and paths, both owned and unsized, in both directions.

ACP: rust-lang/libs-team#151

@bors bors added the S-waiting-on-bors

Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

label

Aug 16, 2025

jhpratt added a commit to jhpratt/rust that referenced this pull request

Aug 17, 2025
…h, r=Amanieu

`impl PartialEq<{str,String}> for {Path,PathBuf}`

This is a revival of rust-lang#105877

Comparison of paths and strings is expected to be possible and needed e.g. in tests. This change adds the impls os `PartialEq` between strings and paths, both owned and unsized, in both directions.

ACP: rust-lang/libs-team#151

jhpratt added a commit to jhpratt/rust that referenced this pull request

Aug 17, 2025
…h, r=Amanieu

`impl PartialEq<{str,String}> for {Path,PathBuf}`

This is a revival of rust-lang#105877

Comparison of paths and strings is expected to be possible and needed e.g. in tests. This change adds the impls os `PartialEq` between strings and paths, both owned and unsized, in both directions.

ACP: rust-lang/libs-team#151

jhpratt added a commit to jhpratt/rust that referenced this pull request

Aug 17, 2025
…h, r=Amanieu

`impl PartialEq<{str,String}> for {Path,PathBuf}`

This is a revival of rust-lang#105877

Comparison of paths and strings is expected to be possible and needed e.g. in tests. This change adds the impls os `PartialEq` between strings and paths, both owned and unsized, in both directions.

ACP: rust-lang/libs-team#151

Zalathar added a commit to Zalathar/rust that referenced this pull request

Aug 18, 2025
…h, r=Amanieu

`impl PartialEq<{str,String}> for {Path,PathBuf}`

This is a revival of rust-lang#105877

Comparison of paths and strings is expected to be possible and needed e.g. in tests. This change adds the impls os `PartialEq` between strings and paths, both owned and unsized, in both directions.

ACP: rust-lang/libs-team#151

bors added a commit that referenced this pull request

Aug 18, 2025
Rollup of 19 pull requests

Successful merges:

 - #140956 (`impl PartialEq<{str,String}> for {Path,PathBuf}`)
 - #141744 (Stabilize `ip_from`)
 - #144804 (Don't warn on never to any `as` casts as unreachable)
 - #144983 (Rehome 37 `tests/ui/issues/` tests to other subdirectories under `tests/ui/`)
 - #145025 (run spellcheck as a tidy extra check in ci)
 - #145041 (rework GAT borrowck limitation error)
 - #145243 (take attr style into account in diagnostics)
 - #145359 (Fix bug where `rustdoc-js` tester would not pick the right `search.js` file if there is more than one)
 - #145429 (Couple of codegen_fn_attrs improvements)
 - #145452 (Do not strip binaries in bootstrap everytime if they are unchanged)
 - #145486 (Fix `unicode_data.rs` mention message)
 - #145489 (library: Migrate from `cfg_if` to `cfg_select`)
 - #145493 (remove `should_render` in `PrintAttribute` derive)
 - #145500 (Port must_use to the new target checking)
 - #145505 (Simplify span caches)
 - #145511 (Rust build fails on OpenBSD after using file_lock feature)
 - #145516 (Weekly `cargo update`)
 - #145533 (Reorder `lto` options from most to least optimizing)
 - #145550 (Avoid using `()` in `derive(From)` output.)

r? `@ghost`
`@rustbot` modify labels: rollup

Zalathar added a commit to Zalathar/rust that referenced this pull request

Aug 18, 2025
…h, r=Amanieu

`impl PartialEq<{str,String}> for {Path,PathBuf}`

This is a revival of rust-lang#105877

Comparison of paths and strings is expected to be possible and needed e.g. in tests. This change adds the impls os `PartialEq` between strings and paths, both owned and unsized, in both directions.

ACP: rust-lang/libs-team#151

Zalathar added a commit to Zalathar/rust that referenced this pull request

Aug 19, 2025
…h, r=Amanieu

`impl PartialEq<{str,String}> for {Path,PathBuf}`

This is a revival of rust-lang#105877

Comparison of paths and strings is expected to be possible and needed e.g. in tests. This change adds the impls os `PartialEq` between strings and paths, both owned and unsized, in both directions.

ACP: rust-lang/libs-team#151

Zalathar added a commit to Zalathar/rust that referenced this pull request

Aug 19, 2025
…h, r=Amanieu

`impl PartialEq<{str,String}> for {Path,PathBuf}`

This is a revival of rust-lang#105877

Comparison of paths and strings is expected to be possible and needed e.g. in tests. This change adds the impls os `PartialEq` between strings and paths, both owned and unsized, in both directions.

ACP: rust-lang/libs-team#151

bors added a commit that referenced this pull request

Aug 19, 2025
Rollup of 19 pull requests

Successful merges:

 - #140956 (`impl PartialEq<{str,String}> for {Path,PathBuf}`)
 - #141744 (Stabilize `ip_from`)
 - #142681 (Remove the `#[no_sanitize]` attribute in favor of `#[sanitize(xyz = "on|off")]`)
 - #142871 (Trivial improve doc for transpose )
 - #144252 (Do not copy .rmeta files into the sysroot of the build compiler during check of rustc/std)
 - #144476 (rustdoc-search: search backend with partitioned suffix tree)
 - #144567 (Fix RISC-V Test Failures in ./x test for Multiple Codegen Cases)
 - #144804 (Don't warn on never to any `as` casts as unreachable)
 - #144960 ([RTE-513] Ignore sleep_until test on SGX)
 - #145013 (overhaul `&mut` suggestions in borrowck errors)
 - #145041 (rework GAT borrowck limitation error)
 - #145243 (take attr style into account in diagnostics)
 - #145405 (cleanup: use run_in_tmpdir in run-make/rustdoc-scrape-examples-paths)
 - #145432 (cg_llvm: Small cleanups to `owned_target_machine`)
 - #145484 (Remove `LlvmArchiveBuilder` and supporting code/bindings)
 - #145557 (Fix uplifting in `Assemble` step)
 - #145563 (Remove the `From` derive macro from prelude)
 - #145565 (Improve context of bootstrap errors in CI)
 - #145584 (interpret: avoid forcing all integer newtypes into memory during clear_provenance)

Failed merges:

 - #145359 (Fix bug where `rustdoc-js` tester would not pick the right `search.js` file if there is more than one)
 - #145573 (Add an experimental unsafe(force_target_feature) attribute.)

r? `@ghost`
`@rustbot` modify labels: rollup

rust-timer added a commit that referenced this pull request

Aug 19, 2025
Rollup merge of #140956 - Kixunil:impl-partialeq-str-for-path, r=Amanieu

`impl PartialEq<{str,String}> for {Path,PathBuf}`

This is a revival of #105877

Comparison of paths and strings is expected to be possible and needed e.g. in tests. This change adds the impls os `PartialEq` between strings and paths, both owned and unsized, in both directions.

ACP: rust-lang/libs-team#151

@Kixunil Kixunil deleted the impl-partialeq-str-for-path branch

August 19, 2025 09:01

@bors bors added S-waiting-on-author

Status: This is awaiting some action (such as code changes or more information) from the author.

S-waiting-on-bors

Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

and removed S-waiting-on-bors

Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

S-waiting-on-author

Status: This is awaiting some action (such as code changes or more information) from the author.

labels

Aug 19, 2025

github-actions bot pushed a commit to model-checking/verify-rust-std that referenced this pull request

Aug 20, 2025
…h, r=Amanieu

`impl PartialEq<{str,String}> for {Path,PathBuf}`

This is a revival of rust-lang#105877

Comparison of paths and strings is expected to be possible and needed e.g. in tests. This change adds the impls os `PartialEq` between strings and paths, both owned and unsized, in both directions.

ACP: rust-lang/libs-team#151

github-actions bot pushed a commit to rust-lang/rustc-dev-guide that referenced this pull request

Aug 25, 2025

This was referenced

Sep 4, 2025

@hkBst hkBst mentioned this pull request

Sep 23, 2025