[win] Use a dash instead of slash for linker to avoid breaking lld by dpaoliello · Pull Request #140977 · rust-lang/rust
rustbot
added
S-waiting-on-review
labels
May 13, 2025
bors
added
S-waiting-on-bors
and removed S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.labels
May 14, 2025bors added a commit to rust-lang-ci/rust that referenced this pull request
May 14, 2025[win] Use a dash instead of slash for linker to avoid breaking lld rust-lang#140758 added the `/arm64hazardfree` linker arg for aarch64-pc-windows-msvc, unfortunately this breaks linking with `lld` as it 1) doesn't understand the arguments and 2) assumes that unknown args that start with `/` are input files. Fix is to use a dash for the arg: `-arm64hazardfree` r? `@wesleywiser`
bors
added
S-waiting-on-review
and removed S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.labels
May 14, 2025
bors
added
S-waiting-on-bors
and removed S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.labels
May 14, 2025jieyouxu added a commit to jieyouxu/rust that referenced this pull request
May 14, 2025[win] Use a dash instead of slash for linker to avoid breaking lld rust-lang#140758 added the `/arm64hazardfree` linker arg for aarch64-pc-windows-msvc, unfortunately this breaks linking with `lld` as it 1) doesn't understand the arguments and 2) assumes that unknown args that start with `/` are input files. Fix is to use a dash for the arg: `-arm64hazardfree` r? `@wesleywiser`
bors added a commit to rust-lang-ci/rust that referenced this pull request
May 14, 2025Rollup of 4 pull requests Successful merges: - rust-lang#140953 (Fix a compiletest blessing message) - rust-lang#140973 (Update rustix to 1.0.7 for bootstrap) - rust-lang#140976 (Add `Ipv4Addr` and `Ipv6Addr` diagnostic items) - rust-lang#140977 ([win] Use a dash instead of slash for linker to avoid breaking lld) r? `@ghost` `@rustbot` modify labels: rollup
compiler-errors added a commit to compiler-errors/rust that referenced this pull request
May 15, 2025[win] Use a dash instead of slash for linker to avoid breaking lld rust-lang#140758 added the `/arm64hazardfree` linker arg for aarch64-pc-windows-msvc, unfortunately this breaks linking with `lld` as it 1) doesn't understand the arguments and 2) assumes that unknown args that start with `/` are input files. Fix is to use a dash for the arg: `-arm64hazardfree` r? `@wesleywiser`
bors added a commit to rust-lang-ci/rust that referenced this pull request
May 15, 2025…mpiler-errors Rollup of 14 pull requests Successful merges: - rust-lang#139749 (docs(library/core/src/pin): fix typo "necessarily" -> "necessary") - rust-lang#140130 (Add LLDB providers for BTreeMap and BTreeSet) - rust-lang#140685 (Simplify `Vec::as_non_null` implementation and make it `const`) - rust-lang#140712 (normalization: avoid incompletely constraining GAT args) - rust-lang#140768 (Improve `dangerous_implicit_aurorefs` diagnostic output) - rust-lang#140834 (move (or remove) some impl Trait tests) - rust-lang#140910 (Remove `stable` attribute from wasi fs (read_exact|write_all)_at) - rust-lang#140947 (Flush errors before deep normalize in `dropck_outlives`) - rust-lang#140966 (Remove #![feature(let_chains)] from library and src/librustdoc) - rust-lang#140977 ([win] Use a dash instead of slash for linker to avoid breaking lld) - rust-lang#140990 (VxWorks: updates from recent libc versions) - rust-lang#141003 (Improve ternary operator recovery) - rust-lang#141013 (Implement methods to set STARTUPINFO flags for Command API on Windows) - rust-lang#141026 (rustc-dev-guide subtree update) r? `@ghost` `@rustbot` modify labels: rollup
fmease added a commit to fmease/rust that referenced this pull request
May 18, 2025[win][arm64] Remove 'Arm64 Hazard' undocumented MSVC option and instead disable problematic test PR rust-lang#140758 added the undocumented `/arm64hazardfree` MSVC linker flag to work around a test failure where LLVM generated code that would trip a hazard in an outdated ARM processor. Adding this flag caused issues with LLD, as it doesn't recognize it. Rethinking the issue, using the undocumented flag seems like the incorrect solution: there's no guarantee that the flag won't be removed in the future, or change its meaning. Instead, I've disabled the problematic test for Arm64 Windows and have filed a bug with the MSVC team to have the check removed: <https://developercommunity.microsoft.com/t/Remove-checking-for-and-fixing-Cortex-A/10905134> This PR supersedes rust-lang#140977 r? `@jieyouxu`
fmease added a commit to fmease/rust that referenced this pull request
May 18, 2025[win][arm64] Remove 'Arm64 Hazard' undocumented MSVC option and instead disable problematic test PR rust-lang#140758 added the undocumented `/arm64hazardfree` MSVC linker flag to work around a test failure where LLVM generated code that would trip a hazard in an outdated ARM processor. Adding this flag caused issues with LLD, as it doesn't recognize it. Rethinking the issue, using the undocumented flag seems like the incorrect solution: there's no guarantee that the flag won't be removed in the future, or change its meaning. Instead, I've disabled the problematic test for Arm64 Windows and have filed a bug with the MSVC team to have the check removed: <https://developercommunity.microsoft.com/t/Remove-checking-for-and-fixing-Cortex-A/10905134> This PR supersedes rust-lang#140977 r? ``@jieyouxu``
fmease added a commit to fmease/rust that referenced this pull request
May 18, 2025[win][arm64] Remove 'Arm64 Hazard' undocumented MSVC option and instead disable problematic test PR rust-lang#140758 added the undocumented `/arm64hazardfree` MSVC linker flag to work around a test failure where LLVM generated code that would trip a hazard in an outdated ARM processor. Adding this flag caused issues with LLD, as it doesn't recognize it. Rethinking the issue, using the undocumented flag seems like the incorrect solution: there's no guarantee that the flag won't be removed in the future, or change its meaning. Instead, I've disabled the problematic test for Arm64 Windows and have filed a bug with the MSVC team to have the check removed: <https://developercommunity.microsoft.com/t/Remove-checking-for-and-fixing-Cortex-A/10905134> This PR supersedes rust-lang#140977 r? ```@jieyouxu```
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request
May 18, 2025Rollup merge of rust-lang#141045 - dpaoliello:noarmhazard, r=jieyouxu [win][arm64] Remove 'Arm64 Hazard' undocumented MSVC option and instead disable problematic test PR rust-lang#140758 added the undocumented `/arm64hazardfree` MSVC linker flag to work around a test failure where LLVM generated code that would trip a hazard in an outdated ARM processor. Adding this flag caused issues with LLD, as it doesn't recognize it. Rethinking the issue, using the undocumented flag seems like the incorrect solution: there's no guarantee that the flag won't be removed in the future, or change its meaning. Instead, I've disabled the problematic test for Arm64 Windows and have filed a bug with the MSVC team to have the check removed: <https://developercommunity.microsoft.com/t/Remove-checking-for-and-fixing-Cortex-A/10905134> This PR supersedes rust-lang#140977 r? ```@jieyouxu```
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters