Implement send_signal for unix child processes by Qelxiros · Pull Request #141990 · rust-lang/rust

@rustbot rustbot added O-unix

Operating system: Unix-like

S-waiting-on-review

Status: Awaiting review from the assignee but also interested parties.

T-libs

Relevant to the library team, which will review and decide on the PR/issue.

labels

Jun 3, 2025

ChrisDenton

@rustbot rustbot added S-waiting-on-review

Status: Awaiting review from the assignee but also interested parties.

and removed S-waiting-on-author

Status: This is awaiting some action (such as code changes or more information) from the author.

labels

Jun 7, 2025

@bors bors added S-waiting-on-bors

Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

and removed S-waiting-on-review

Status: Awaiting review from the assignee but also interested parties.

labels

Jun 15, 2025

tgross35 added a commit to tgross35/rust that referenced this pull request

Jun 16, 2025
…r=ChrisDenton

Implement send_signal for unix child processes

Tracking issue: rust-lang#141975

There are two main differences between my implementation and the Public API section of the tracking issue. ~First, `send_signal` requires a mutable reference, like `Child::kill`.~ Second, `ChildExt` has `Sealed` as a supertrait, bringing it more in line with other extension traits like `CommandExt`.

bors added a commit that referenced this pull request

Jun 16, 2025
Rollup of 7 pull requests

Successful merges:

 - #138237 (Get rid of `EscapeDebugInner`.)
 - #140809 (Reduce special casing for the panic runtime)
 - #141990 (Implement send_signal for unix child processes)
 - #142082 (Refactor `rustc_attr_data_structures` documentation)
 - #142125 (Stabilize "file_lock" feature)
 - #142528 (clarify `rustc_do_not_const_check` comment)
 - #142530 (use `if let` guards where possible)

r? `@ghost`
`@rustbot` modify labels: rollup

@bors bors added S-waiting-on-author

Status: This is awaiting some action (such as code changes or more information) from the author.

and removed S-waiting-on-bors

Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

labels

Jun 16, 2025

tgross35

@bors bors added S-waiting-on-bors

Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

and removed S-waiting-on-review

Status: Awaiting review from the assignee but also interested parties.

labels

Jun 18, 2025

Kobzol added a commit to Kobzol/rust that referenced this pull request

Jun 19, 2025
…r=ChrisDenton,tgross35

Implement send_signal for unix child processes

Tracking issue: rust-lang#141975

There are two main differences between my implementation and the Public API section of the tracking issue. ~First, `send_signal` requires a mutable reference, like `Child::kill`.~ Second, `ChildExt` has `Sealed` as a supertrait, bringing it more in line with other extension traits like `CommandExt`.

try-job: `dist-various*`
try-job: `test-various*`

bors added a commit that referenced this pull request

Jun 19, 2025
Rollup of 6 pull requests

Successful merges:

 - #141990 (Implement send_signal for unix child processes)
 - #142331 (Add `trim_prefix` and `trim_suffix` methods for both `slice` and `str` types.)
 - #142502 (rustdoc_json: improve handling of generic args)
 - #142629 (Add config builder for bootstrap tests)
 - #142687 (Reduce uses of `hir_crate`.)
 - #142714 (add comment to `src/bootstrap/build.rs`)

r? `@ghost`
`@rustbot` modify labels: rollup

jhpratt added a commit to jhpratt/rust that referenced this pull request

Jun 19, 2025
…r=ChrisDenton,tgross35

Implement send_signal for unix child processes

Tracking issue: rust-lang#141975

There are two main differences between my implementation and the Public API section of the tracking issue. ~First, `send_signal` requires a mutable reference, like `Child::kill`.~ Second, `ChildExt` has `Sealed` as a supertrait, bringing it more in line with other extension traits like `CommandExt`.

try-job: `dist-various*`
try-job: `test-various*`

bors added a commit that referenced this pull request

Jun 19, 2025
Rollup of 10 pull requests

Successful merges:

 - #138291 (rewrite `optimize` attribute to use new attribute parsing infrastructure)
 - #141990 (Implement send_signal for unix child processes)
 - #142331 (Add `trim_prefix` and `trim_suffix` methods for both `slice` and `str` types.)
 - #142478 (install docs for each target in different directory)
 - #142571 (Reason about borrowed classes in CopyProp.)
 - #142668 (vec_deque/fmt/vec tests: remove static mut)
 - #142687 (Reduce uses of `hir_crate`.)
 - #142690 (expand: Remove some unnecessary generic parameters)
 - #142699 (Update books)
 - #142714 (add comment to `src/bootstrap/build.rs`)

Failed merges:

 - #142502 (rustdoc_json: improve handling of generic args)

r? `@ghost`
`@rustbot` modify labels: rollup

tgross35 added a commit to tgross35/rust that referenced this pull request

Jun 20, 2025
…r=ChrisDenton,tgross35

Implement send_signal for unix child processes

Tracking issue: rust-lang#141975

There are two main differences between my implementation and the Public API section of the tracking issue. ~First, `send_signal` requires a mutable reference, like `Child::kill`.~ Second, `ChildExt` has `Sealed` as a supertrait, bringing it more in line with other extension traits like `CommandExt`.

try-job: `dist-various*`
try-job: `test-various*`

bors added a commit that referenced this pull request

Jun 20, 2025
Rollup of 8 pull requests

Successful merges:

 - #138291 (rewrite `optimize` attribute to use new attribute parsing infrastructure)
 - #140920 (Extract some shared code from codegen backend target feature handling)
 - #141990 (Implement send_signal for unix child processes)
 - #142597 (error on calls to ABIs that cannot be called)
 - #142668 (vec_deque/fmt/vec tests: remove static mut)
 - #142687 (Reduce uses of `hir_crate`.)
 - #142699 (Update books)
 - #142714 (add comment to `src/bootstrap/build.rs`)

r? `@ghost`
`@rustbot` modify labels: rollup

bors added a commit that referenced this pull request

Jun 20, 2025
Rollup of 8 pull requests

Successful merges:

 - #138291 (rewrite `optimize` attribute to use new attribute parsing infrastructure)
 - #140920 (Extract some shared code from codegen backend target feature handling)
 - #141990 (Implement send_signal for unix child processes)
 - #142668 (vec_deque/fmt/vec tests: remove static mut)
 - #142687 (Reduce uses of `hir_crate`.)
 - #142699 (Update books)
 - #142714 (add comment to `src/bootstrap/build.rs`)
 - #142753 (Update library dependencies)

r? `@ghost`
`@rustbot` modify labels: rollup

rust-timer added a commit that referenced this pull request

Jun 20, 2025
Rollup merge of #141990 - Qelxiros:141975-unix_send_signal, r=ChrisDenton,tgross35

Implement send_signal for unix child processes

Tracking issue: #141975

There are two main differences between my implementation and the Public API section of the tracking issue. ~First, `send_signal` requires a mutable reference, like `Child::kill`.~ Second, `ChildExt` has `Sealed` as a supertrait, bringing it more in line with other extension traits like `CommandExt`.

try-job: `dist-various*`
try-job: `test-various*`

matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request

Jun 28, 2025
…t, r=Mark-Simulacrum

update internal `send_signal` comment

the vxwork did not have the old comment updated in rust-lang#141990 so update here;

signaling -> sending signals to because the latter reads better to me.

matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request

Jun 28, 2025
…t, r=Mark-Simulacrum

update internal `send_signal` comment

the vxwork did not have the old comment updated in rust-lang#141990 so update here;

signaling -> sending signals to because the latter reads better to me.

matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request

Jun 28, 2025
…t, r=Mark-Simulacrum

update internal `send_signal` comment

the vxwork did not have the old comment updated in rust-lang#141990 so update here;

signaling -> sending signals to because the latter reads better to me.

matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request

Jun 28, 2025
…t, r=Mark-Simulacrum

update internal `send_signal` comment

the vxwork did not have the old comment updated in rust-lang#141990 so update here;

signaling -> sending signals to because the latter reads better to me.

matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request

Jun 28, 2025
…t, r=Mark-Simulacrum

update internal `send_signal` comment

the vxwork did not have the old comment updated in rust-lang#141990 so update here;

signaling -> sending signals to because the latter reads better to me.

rust-timer added a commit that referenced this pull request

Jun 29, 2025
Rollup merge of #143082 - fee1-dead-contrib:push-qvvppzukvkxt, r=Mark-Simulacrum

update internal `send_signal` comment

the vxwork did not have the old comment updated in #141990 so update here;

signaling -> sending signals to because the latter reads better to me.

github-actions bot pushed a commit to rust-lang/miri that referenced this pull request

Jun 29, 2025
…-Simulacrum

update internal `send_signal` comment

the vxwork did not have the old comment updated in rust-lang/rust#141990 so update here;

signaling -> sending signals to because the latter reads better to me.

tautschnig pushed a commit to model-checking/verify-rust-std that referenced this pull request

Jul 3, 2025
…r=ChrisDenton,tgross35

Implement send_signal for unix child processes

Tracking issue: rust-lang#141975

There are two main differences between my implementation and the Public API section of the tracking issue. ~First, `send_signal` requires a mutable reference, like `Child::kill`.~ Second, `ChildExt` has `Sealed` as a supertrait, bringing it more in line with other extension traits like `CommandExt`.

try-job: `dist-various*`
try-job: `test-various*`

github-actions bot pushed a commit to model-checking/verify-rust-std that referenced this pull request

Jul 4, 2025
…t, r=Mark-Simulacrum

update internal `send_signal` comment

the vxwork did not have the old comment updated in rust-lang#141990 so update here;

signaling -> sending signals to because the latter reads better to me.

@Qelxiros Qelxiros deleted the 141975-unix_send_signal branch

September 14, 2025 21:05