Home Original page

Use the `new` method for `BasicBlockData` and `Statement` by dianqk · Pull Request #143190 · rust-lang/rust

@dianqk 

Avoid introducing a large number of changes when adding optional initialization fields.

@rustbot rustbot added S-waiting-on-review

Status: Awaiting review from the assignee but also interested parties.

T-compiler

Relevant to the compiler team, which will review and decide on the PR/issue.

labels

Jun 29, 2025

@dianqk

@bors bors added S-waiting-on-bors

Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

and removed S-waiting-on-review

Status: Awaiting review from the assignee but also interested parties.

labels

Jun 30, 2025

bors added a commit that referenced this pull request

Jun 30, 2025 
Rollup of 14 pull requests

Successful merges:

 - #142429 (`tests/ui`: A New Order [13/N])
 - #142514 (Miri: handling of SNaN inputs in `f*::pow` operations)
 - #143066 (Use let chains in the new solver)
 - #143090 (Workaround for memory unsafety in third party DLLs)
 - #143118 (`tests/ui`: A New Order [15/N])
 - #143159 (Do not freshen `ReError`)
 - #143168 (`tests/ui`: A New Order [16/N])
 - #143176 (fix typos and improve clarity in documentation)
 - #143187 (Add my work email to mailmap)
 - #143190 (Use the `new` method for `BasicBlockData` and `Statement`)
 - #143195 (`tests/ui`: A New Order [17/N])
 - #143196 (Port #[link_section] to the new attribute parsing infrastructure)
 - #143199 (Re-disable `tests/run-make/short-ice` on Windows MSVC again)
 - #143219 (Show auto trait and blanket impls for `!`)

r? `@ghost`
`@rustbot` modify labels: rollup

rust-timer added a commit that referenced this pull request

Jun 30, 2025 
Rollup merge of #143190 - dianqk:new-method, r=oli-obk

Use the `new` method for `BasicBlockData` and `Statement`

This is the NFC part of #142771. I split it to make it easier to review for #142771. Even without #142771, I think this change is worthwhile.

github-actions bot pushed a commit to rust-lang/miri that referenced this pull request

Jul 1, 2025

Kobzol pushed a commit to Kobzol/stdarch that referenced this pull request

Jul 2, 2025

github-actions bot pushed a commit to rust-lang/rustc-dev-guide that referenced this pull request

Jul 3, 2025

github-actions bot pushed a commit to model-checking/verify-rust-std that referenced this pull request

Jul 4, 2025

Kobzol pushed a commit to Kobzol/rustc_codegen_cranelift that referenced this pull request

Dec 29, 2025