constify `Option` methods by oli-obk · Pull Request #143967

constify `Option` methods by oli-obk · Pull Request #143967 · rust-lang/rust

rustbot added S-waiting-on-review

Status: Awaiting review from the assignee but also interested parties.

T-libs

Relevant to the library team, which will review and decide on the PR/issue.

labels

Jul 15, 2025

rustbot added S-waiting-on-author

Status: This is awaiting some action (such as code changes or more information) from the author.

and removed S-waiting-on-review

Status: Awaiting review from the assignee but also interested parties.

labels

Jul 17, 2025

bors added S-waiting-on-bors

Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

and removed S-waiting-on-author

Status: This is awaiting some action (such as code changes or more information) from the author.

labels

Jul 17, 2025

fmease added a commit to fmease/rust that referenced this pull request

Jul 17, 2025

…e1-dead

constify `Option` methods

r? `@fee1-dead`

tracking issue: rust-lang#143956

these unblock making `PartialOrd` and `Ord` const without resorting to inlining some of these at call sites.

fmease added a commit to fmease/rust that referenced this pull request

Jul 17, 2025

…e1-dead

constify `Option` methods

r? ``@fee1-dead``

tracking issue: rust-lang#143956

these unblock making `PartialOrd` and `Ord` const without resorting to inlining some of these at call sites.

bors added a commit that referenced this pull request

Jul 17, 2025

Rollup of 15 pull requests

Successful merges:

 - #142300 (Disable `tests/run-make/mte-ffi` because no CI runners have MTE extensions enabled)
 - #143271 (Store the type of each GVN value)
 - #143293 (fix `-Zsanitizer=kcfi` on `#[naked]` functions)
 - #143719 (Emit warning when there is no space between `-o` and arg)
 - #143833 (Ban projecting into SIMD types [MCP838])
 - #143846 (pass --gc-sections if -Zexport-executable-symbols is enabled and improve tests)
 - #143879 (parse `const trait Trait`)
 - #143891 (Port `#[coverage]` to the new attribute system)
 - #143967 (constify `Option` methods)
 - #143985 (rustc_public: de-StableMIR-ize)
 - #144008 (Fix false positive double negations with macro invocation)
 - #144010 (Boostrap: add warning on `optimize = false`)
 - #144034 (tests: Test line number in debuginfo for diverging function calls)
 - #144049 (rustc-dev-guide subtree update)
 - #144056 (Copy GCC sources into the build directory even outside CI)

r? `@ghost`
`@rustbot` modify labels: rollup

matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request

Jul 17, 2025

…e1-dead

constify `Option` methods

r? ```@fee1-dead```

tracking issue: rust-lang#143956

these unblock making `PartialOrd` and `Ord` const without resorting to inlining some of these at call sites.

bors added a commit that referenced this pull request

Jul 17, 2025

Rollup of 12 pull requests

Successful merges:

 - #142300 (Disable `tests/run-make/mte-ffi` because no CI runners have MTE extensions enabled)
 - #143271 (Store the type of each GVN value)
 - #143293 (fix `-Zsanitizer=kcfi` on `#[naked]` functions)
 - #143719 (Emit warning when there is no space between `-o` and arg)
 - #143846 (pass --gc-sections if -Zexport-executable-symbols is enabled and improve tests)
 - #143891 (Port `#[coverage]` to the new attribute system)
 - #143967 (constify `Option` methods)
 - #144008 (Fix false positive double negations with macro invocation)
 - #144010 (Boostrap: add warning on `optimize = false`)
 - #144034 (tests: Test line number in debuginfo for diverging function calls)
 - #144049 (rustc-dev-guide subtree update)
 - #144056 (Copy GCC sources into the build directory even outside CI)

r? `@ghost`
`@rustbot` modify labels: rollup

bors added a commit that referenced this pull request

Jul 17, 2025

Rollup of 12 pull requests

Successful merges:

 - #142300 (Disable `tests/run-make/mte-ffi` because no CI runners have MTE extensions enabled)
 - #143271 (Store the type of each GVN value)
 - #143293 (fix `-Zsanitizer=kcfi` on `#[naked]` functions)
 - #143719 (Emit warning when there is no space between `-o` and arg)
 - #143846 (pass --gc-sections if -Zexport-executable-symbols is enabled and improve tests)
 - #143891 (Port `#[coverage]` to the new attribute system)
 - #143967 (constify `Option` methods)
 - #144008 (Fix false positive double negations with macro invocation)
 - #144010 (Boostrap: add warning on `optimize = false`)
 - #144034 (tests: Test line number in debuginfo for diverging function calls)
 - #144049 (rustc-dev-guide subtree update)
 - #144056 (Copy GCC sources into the build directory even outside CI)

r? `@ghost`
`@rustbot` modify labels: rollup

jhpratt added a commit to jhpratt/rust that referenced this pull request

Jul 18, 2025

…e1-dead

constify `Option` methods

r? ````@fee1-dead````

tracking issue: rust-lang#143956

these unblock making `PartialOrd` and `Ord` const without resorting to inlining some of these at call sites.

matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request

Jul 18, 2025

…e1-dead

constify `Option` methods

r? `````@fee1-dead`````

tracking issue: rust-lang#143956

these unblock making `PartialOrd` and `Ord` const without resorting to inlining some of these at call sites.

matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request

Jul 18, 2025

…e1-dead

constify `Option` methods

r? ``````@fee1-dead``````

tracking issue: rust-lang#143956

these unblock making `PartialOrd` and `Ord` const without resorting to inlining some of these at call sites.

This was referenced

Jul 18, 2025

bors added a commit that referenced this pull request

Jul 18, 2025

Rollup of 11 pull requests

Successful merges:

 - #142300 (Disable `tests/run-make/mte-ffi` because no CI runners have MTE extensions enabled)
 - #143271 (Store the type of each GVN value)
 - #143293 (fix `-Zsanitizer=kcfi` on `#[naked]` functions)
 - #143719 (Emit warning when there is no space between `-o` and arg)
 - #143846 (pass --gc-sections if -Zexport-executable-symbols is enabled and improve tests)
 - #143891 (Port `#[coverage]` to the new attribute system)
 - #143967 (constify `Option` methods)
 - #144008 (Fix false positive double negations with macro invocation)
 - #144010 (Boostrap: add warning on `optimize = false`)
 - #144049 (rustc-dev-guide subtree update)
 - #144056 (Copy GCC sources into the build directory even outside CI)

r? `@ghost`
`@rustbot` modify labels: rollup

rust-timer added a commit that referenced this pull request

Jul 18, 2025

Rollup merge of #143967 - oli-obk:const-option-methods, r=fee1-dead

constify `Option` methods

r? ```````@fee1-dead```````

tracking issue: #143956

these unblock making `PartialOrd` and `Ord` const without resorting to inlining some of these at call sites.

github-actions bot pushed a commit to rust-lang/miri that referenced this pull request

Jul 19, 2025

github-actions bot pushed a commit to rust-lang/rustc-dev-guide that referenced this pull request

Jul 21, 2025

Muscraft pushed a commit to Muscraft/rust that referenced this pull request

Jul 21, 2025

…e1-dead

constify `Option` methods

r? ```````@fee1-dead```````

tracking issue: rust-lang#143956

these unblock making `PartialOrd` and `Ord` const without resorting to inlining some of these at call sites.

Muscraft pushed a commit to Muscraft/rust that referenced this pull request

Jul 21, 2025

…iaskrgr

Rollup of 11 pull requests

Successful merges:

 - rust-lang#142300 (Disable `tests/run-make/mte-ffi` because no CI runners have MTE extensions enabled)
 - rust-lang#143271 (Store the type of each GVN value)
 - rust-lang#143293 (fix `-Zsanitizer=kcfi` on `#[naked]` functions)
 - rust-lang#143719 (Emit warning when there is no space between `-o` and arg)
 - rust-lang#143846 (pass --gc-sections if -Zexport-executable-symbols is enabled and improve tests)
 - rust-lang#143891 (Port `#[coverage]` to the new attribute system)
 - rust-lang#143967 (constify `Option` methods)
 - rust-lang#144008 (Fix false positive double negations with macro invocation)
 - rust-lang#144010 (Boostrap: add warning on `optimize = false`)
 - rust-lang#144049 (rustc-dev-guide subtree update)
 - rust-lang#144056 (Copy GCC sources into the build directory even outside CI)

r? `@ghost`
`@rustbot` modify labels: rollup

github-actions bot pushed a commit to model-checking/verify-rust-std that referenced this pull request

Jul 29, 2025

…e1-dead

constify `Option` methods

r? ```````@fee1-dead```````

tracking issue: rust-lang#143956

these unblock making `PartialOrd` and `Ord` const without resorting to inlining some of these at call sites.

Kobzol pushed a commit to Kobzol/rustc_codegen_gcc that referenced this pull request

Dec 21, 2025

Kobzol pushed a commit to Kobzol/rustc_codegen_cranelift that referenced this pull request

Dec 29, 2025

christian-schilling pushed a commit to christian-schilling/rustc_codegen_cranelift that referenced this pull request

Jan 27, 2026

christian-schilling pushed a commit to christian-schilling/rustc_codegen_cranelift that referenced this pull request

Jan 27, 2026