Fix doc comment of File::try_lock and File::try_lock_shared by ulrichstark · Pull Request #145046

Fix doc comment of File::try_lock and File::try_lock_shared by ulrichstark · Pull Request #145046 · rust-lang/rust

rustbot added S-waiting-on-review

Status: Awaiting review from the assignee but also interested parties.

T-libs

Relevant to the library team, which will review and decide on the PR/issue.

labels

Aug 7, 2025

bors added S-waiting-on-bors

Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

and removed S-waiting-on-review

Status: Awaiting review from the assignee but also interested parties.

labels

Aug 7, 2025

tgross35 added a commit to tgross35/rust that referenced this pull request

Aug 7, 2025

Fix doc comment of File::try_lock and File::try_lock_shared

The doc comments of functions `File::try_lock` and `File::try_lock_shared` stabilized today in version 1.89.0 document an incorrect type of `Ok`.

The result type was changed in rust-lang#139343 after the latest change to the doc comments in rust-lang#136876.

bors added a commit that referenced this pull request

Aug 7, 2025

Rollup of 6 pull requests

Successful merges:

 - #144400 (`tests/ui/issues/`: The Issues Strike Back [3/N])
 - #144678 (Make no_mangle on foreign items explicit instead of implicit)
 - #145045 (doc(library): Fix Markdown in `Iterator::by_ref`)
 - #145046 (Fix doc comment of File::try_lock and File::try_lock_shared)
 - #145047 (move `type_check` out of `compute_regions`)
 - #145053 (Add a lot of NLL `known-bug` tests)

r? `@ghost`
`@rustbot` modify labels: rollup

tgross35 added a commit to tgross35/rust that referenced this pull request

Aug 7, 2025

Fix doc comment of File::try_lock and File::try_lock_shared

The doc comments of functions `File::try_lock` and `File::try_lock_shared` stabilized today in version 1.89.0 document an incorrect type of `Ok`.

The result type was changed in rust-lang#139343 after the latest change to the doc comments in rust-lang#136876.

This was referenced

Aug 7, 2025

bors added a commit that referenced this pull request

Aug 8, 2025

Rollup of 9 pull requests

Successful merges:

 - #144705 (compiler-builtins: plumb LSE support for aarch64 on linux/gnu when optimized-compiler-builtins not enabled)
 - #144857 (Port `#[allow_internal_unsafe]` to the new attribute system)
 - #144900 (Stabilize `unsigned_signed_diff` feature)
 - #144903 (Rename `begin_panic_handler` to `panic_handler`)
 - #144974 (compiler-builtins subtree update)
 - #145007 (Fix build/doc/test of error index generator)
 - #145018 (Derive `Hash` for rustc_public types)
 - #145045 (doc(library): Fix Markdown in `Iterator::by_ref`)
 - #145046 (Fix doc comment of File::try_lock and File::try_lock_shared)

r? `@ghost`
`@rustbot` modify labels: rollup

rust-timer added a commit that referenced this pull request

Aug 8, 2025

Rollup merge of #145046 - ulrichstark:master, r=tgross35

Fix doc comment of File::try_lock and File::try_lock_shared

The doc comments of functions `File::try_lock` and `File::try_lock_shared` stabilized today in version 1.89.0 document an incorrect type of `Ok`.

The result type was changed in #139343 after the latest change to the doc comments in #136876.

github-actions bot pushed a commit to rust-lang/compiler-builtins that referenced this pull request

Aug 9, 2025

github-actions bot pushed a commit to rust-lang/miri that referenced this pull request

Aug 9, 2025

github-actions bot pushed a commit to model-checking/verify-rust-std that referenced this pull request

Aug 12, 2025

Fix doc comment of File::try_lock and File::try_lock_shared

The doc comments of functions `File::try_lock` and `File::try_lock_shared` stabilized today in version 1.89.0 document an incorrect type of `Ok`.

The result type was changed in rust-lang#139343 after the latest change to the doc comments in rust-lang#136876.

rust-cloud-vms bot pushed a commit to makai410/rustc_public that referenced this pull request

Aug 16, 2025

rust-cloud-vms bot pushed a commit to makai410/rustc_public that referenced this pull request

Aug 20, 2025

makai410 pushed a commit to makai410/rust that referenced this pull request

Nov 8, 2025

Fix doc comment of File::try_lock and File::try_lock_shared

The doc comments of functions `File::try_lock` and `File::try_lock_shared` stabilized today in version 1.89.0 document an incorrect type of `Ok`.

The result type was changed in rust-lang#139343 after the latest change to the doc comments in rust-lang#136876.

makai410 pushed a commit to makai410/rust that referenced this pull request

Nov 8, 2025

Rollup of 9 pull requests

Successful merges:

 - rust-lang#144705 (compiler-builtins: plumb LSE support for aarch64 on linux/gnu when optimized-compiler-builtins not enabled)
 - rust-lang#144857 (Port `#[allow_internal_unsafe]` to the new attribute system)
 - rust-lang#144900 (Stabilize `unsigned_signed_diff` feature)
 - rust-lang#144903 (Rename `begin_panic_handler` to `panic_handler`)
 - rust-lang#144974 (compiler-builtins subtree update)
 - rust-lang#145007 (Fix build/doc/test of error index generator)
 - rust-lang#145018 (Derive `Hash` for rustc_public types)
 - rust-lang#145045 (doc(library): Fix Markdown in `Iterator::by_ref`)
 - rust-lang#145046 (Fix doc comment of File::try_lock and File::try_lock_shared)

r? `@ghost`
`@rustbot` modify labels: rollup

makai410 pushed a commit to makai410/rust that referenced this pull request

Nov 10, 2025

Fix doc comment of File::try_lock and File::try_lock_shared

The doc comments of functions `File::try_lock` and `File::try_lock_shared` stabilized today in version 1.89.0 document an incorrect type of `Ok`.

The result type was changed in rust-lang#139343 after the latest change to the doc comments in rust-lang#136876.

makai410 pushed a commit to makai410/rust that referenced this pull request

Nov 10, 2025

Rollup of 9 pull requests

Successful merges:

 - rust-lang#144705 (compiler-builtins: plumb LSE support for aarch64 on linux/gnu when optimized-compiler-builtins not enabled)
 - rust-lang#144857 (Port `#[allow_internal_unsafe]` to the new attribute system)
 - rust-lang#144900 (Stabilize `unsigned_signed_diff` feature)
 - rust-lang#144903 (Rename `begin_panic_handler` to `panic_handler`)
 - rust-lang#144974 (compiler-builtins subtree update)
 - rust-lang#145007 (Fix build/doc/test of error index generator)
 - rust-lang#145018 (Derive `Hash` for rustc_public types)
 - rust-lang#145045 (doc(library): Fix Markdown in `Iterator::by_ref`)
 - rust-lang#145046 (Fix doc comment of File::try_lock and File::try_lock_shared)

r? `@ghost`
`@rustbot` modify labels: rollup

makai410 pushed a commit to makai410/rustc_public that referenced this pull request

Nov 16, 2025

tgross35 pushed a commit to rust-lang/compiler-builtins that referenced this pull request

Jan 31, 2026