Rename `Location::file_with_nul` to `file_as_c_str` by Darksonn · Pull Request #145928 · rust-lang/rust

@Darksonn

@Darksonn added T-libs-api

Relevant to the library API team, which will review and decide on the PR/issue.

A-panic

Area: Panicking machinery

labels

Aug 27, 2025

@rustbot rustbot added S-waiting-on-review

Status: Awaiting review from the assignee but also interested parties.

A-CI

Area: Our Github Actions CI

A-testsuite

Area: The testsuite used to check the correctness of rustc

T-infra

Relevant to the infrastructure team, which will review and decide on the PR/issue.

labels

Aug 27, 2025

rust-bors bot added a commit that referenced this pull request

Aug 27, 2025
Rename `Location::file_with_nul` to `file_as_c_str`

try-job: x86_64-rust-for-linux

Darksonn

rust-bors bot added a commit that referenced this pull request

Aug 28, 2025
Rename `Location::file_with_nul` to `file_as_c_str`

try-job: x86_64-rust-for-linux

@ojeda ojeda mentioned this pull request

Aug 21, 2025

48 tasks

@bors bors added S-waiting-on-bors

Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

and removed S-waiting-on-review

Status: Awaiting review from the assignee but also interested parties.

labels

Aug 28, 2025

bors added a commit that referenced this pull request

Aug 28, 2025
Rollup of 9 pull requests

Successful merges:

 - #142727 (wasm: rm static mut)
 - #143193 (Port `#[link]` to the new attribute parsing infrastructure )
 - #144864 (No source fixes)
 - #145913 (Add spin_loop hint for LoongArch)
 - #145926 (compiletest: Remove several remnants of the old libtest-based executor)
 - #145928 (Rename `Location::file_with_nul` to `file_as_c_str`)
 - #145930 (`const`ify (the unstable) `str::as_str`)
 - #145941 (Disable `integer_to_ptr_transmutes` suggestion for unsized types)
 - #145953 (Update `icu_list` to 2.0)

r? `@ghost`
`@rustbot` modify labels: rollup

rust-timer added a commit that referenced this pull request

Aug 28, 2025
Rollup merge of #145928 - Darksonn:file_as_c_str, r=joshtriplett

Rename `Location::file_with_nul` to `file_as_c_str`

This renames the method to be consistent with the ongoing T-libs-api FCP found at #141727 (comment).

I did not rename the unstable feature as we are going to be stabilizing it soon anyway. This will probably break RfL, so it will require an updated commit hash for the Linux Kernel that I will add here soon.

r? `@Amanieu`

ojeda added a commit to ojeda/rust that referenced this pull request

Sep 3, 2025
This upgrades the Rust CI from v6.16-rc1 plus a temporary commit for
the >= 1.91 target spec [1] to v6.17-rc3 with two temporary commits --
one for the same target spec format change [1] and another for the
`file_as_c_str` change [2].

Link: rust-lang#144443 [1]
Link: rust-lang#145928 [2]
Signed-off-by: Miguel Ojeda <ojeda@kernel.org>

ojeda added a commit to ojeda/rust that referenced this pull request

Sep 3, 2025
This upgrades the Rust CI from v6.16-rc1 plus a temporary commit for
the >= 1.91 target spec [1] to v6.17-rc3 with two commits pending to
be merged upstream -- one for the same target spec format change [1]
and another for the `file_as_c_str` change [2].

Link: rust-lang#144443 [1]
Link: rust-lang#145928 [2]
Signed-off-by: Miguel Ojeda <ojeda@kernel.org>

@ojeda ojeda mentioned this pull request

Sep 3, 2025

ojeda added a commit to ojeda/rust that referenced this pull request

Sep 3, 2025
This upgrades the Rust CI from v6.16-rc1 plus a temporary commit for
the >= 1.91 target spec [1] to v6.17-rc3 with two commits pending to
be merged upstream -- one for the same target spec format change [1]
and another for the `file_as_c_str` change [2].

Link: rust-lang#144443 [1]
Link: rust-lang#145928 [2]
Signed-off-by: Miguel Ojeda <ojeda@kernel.org>

Zalathar added a commit to Zalathar/rust that referenced this pull request

Sep 3, 2025
CI: rfl: move job forward to Linux v6.17-rc3 plus 2 commits

This upgrades the Rust CI from v6.16-rc1 plus a temporary commit for the >= 1.91 target spec [1] to v6.17-rc3 with two commits pending to be merged upstream -- one for the same target spec format change [1] and another for the `file_as_c_str` change [2].

Link: rust-lang#144443 [1]
Link: rust-lang#145928 [2]

r? `@lqd` `@Kobzol`
try-job: x86_64-rust-for-linux
`@rustbot` label A-rust-for-linux
`@bors` try

Zalathar added a commit to Zalathar/rust that referenced this pull request

Sep 3, 2025
CI: rfl: move job forward to Linux v6.17-rc3 plus 2 commits

This upgrades the Rust CI from v6.16-rc1 plus a temporary commit for the >= 1.91 target spec [1] to v6.17-rc3 with two commits pending to be merged upstream -- one for the same target spec format change [1] and another for the `file_as_c_str` change [2].

Link: rust-lang#144443 [1]
Link: rust-lang#145928 [2]

r? ``@lqd`` ``@Kobzol``
try-job: x86_64-rust-for-linux
``@rustbot`` label A-rust-for-linux
``@bors`` try

rust-timer added a commit that referenced this pull request

Sep 3, 2025
Rollup merge of #146154 - ojeda:rfl, r=lqd

CI: rfl: move job forward to Linux v6.17-rc3 plus 2 commits

This upgrades the Rust CI from v6.16-rc1 plus a temporary commit for the >= 1.91 target spec [1] to v6.17-rc3 with two commits pending to be merged upstream -- one for the same target spec format change [1] and another for the `file_as_c_str` change [2].

Link: #144443 [1]
Link: #145928 [2]

r? ``@lqd`` ``@Kobzol``
try-job: x86_64-rust-for-linux
``@rustbot`` label A-rust-for-linux
``@bors`` try

github-actions bot pushed a commit to model-checking/verify-rust-std that referenced this pull request

Sep 9, 2025
…lett

Rename `Location::file_with_nul` to `file_as_c_str`

This renames the method to be consistent with the ongoing T-libs-api FCP found at rust-lang#141727 (comment).

I did not rename the unstable feature as we are going to be stabilizing it soon anyway. This will probably break RfL, so it will require an updated commit hash for the Linux Kernel that I will add here soon.

r? `@Amanieu`

@ojeda ojeda mentioned this pull request

Feb 8, 2026

57 tasks