fix a constness ordering bug in rustfmt by npmccallum · Pull Request #146089 · rust-lang/rust

@npmccallum

Normally, changes to rustfmt go into the separate repo. But, in
this case, the bug is introduced in a local change and therefore
isn't present in the rustfmt repo.

@rustbot rustbot added S-waiting-on-review

Status: Awaiting review from the assignee but also interested parties.

T-rustfmt

Relevant to the rustfmt team, which will review and decide on the PR/issue.

labels

Sep 1, 2025

@bors bors added S-waiting-on-bors

Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

and removed S-waiting-on-review

Status: Awaiting review from the assignee but also interested parties.

labels

Sep 1, 2025

fmease added a commit to fmease/rust that referenced this pull request

Sep 1, 2025
fix a constness ordering bug in rustfmt

Normally, changes to rustfmt go into the separate repo. But, in this case, the bug is introduced in a local change and therefore isn't present in the rustfmt repo.

Related to: rust-lang#146071
Fixes rust-lang/rustfmt#6619.

bors added a commit that referenced this pull request

Sep 2, 2025
Rollup of 10 pull requests

Successful merges:

 - #144066 (stabilize c-style varargs for sysv64, win64, efiapi, aapcs)
 - #145783 (add span to struct pattern rest (..))
 - #145961 (resolve: Avoid a regression from splitting prelude into two scopes)
 - #145962 (Ensure we emit an allocator shim when only some crate types need one)
 - #146064 (Add compiler error when trying to use concat metavar expr in repetitions)
 - #146067 (alloc: make Cow From impls const)
 - #146070 (rustdoc-search: skip loading unneeded fnData)
 - #146089 (fix a constness ordering bug in rustfmt)
 - #146094 (Make `Parser::parse_for_head` public for rustfmt usage)
 - #146102 (Remove dead code stemming from an old effects desugaring)

r? `@ghost`
`@rustbot` modify labels: rollup

jhpratt added a commit to jhpratt/rust that referenced this pull request

Sep 2, 2025
fix a constness ordering bug in rustfmt

Normally, changes to rustfmt go into the separate repo. But, in this case, the bug is introduced in a local change and therefore isn't present in the rustfmt repo.

Related to: rust-lang#146071
Fixes rust-lang/rustfmt#6619.

bors added a commit that referenced this pull request

Sep 2, 2025
Rollup of 9 pull requests

Successful merges:

 - #145783 (add span to struct pattern rest (..))
 - #145961 (resolve: Avoid a regression from splitting prelude into two scopes)
 - #145962 (Ensure we emit an allocator shim when only some crate types need one)
 - #146064 (Add compiler error when trying to use concat metavar expr in repetitions)
 - #146067 (alloc: make Cow From impls const)
 - #146070 (rustdoc-search: skip loading unneeded fnData)
 - #146089 (fix a constness ordering bug in rustfmt)
 - #146094 (Make `Parser::parse_for_head` public for rustfmt usage)
 - #146102 (Remove dead code stemming from an old effects desugaring)

r? `@ghost`
`@rustbot` modify labels: rollup

bors added a commit that referenced this pull request

Sep 2, 2025
Rollup of 14 pull requests

Successful merges:

 - #144066 (stabilize c-style varargs for sysv64, win64, efiapi, aapcs)
 - #145783 (add span to struct pattern rest (..))
 - #146034 (Update target spec metadata of Arm64EC Windows and Trusty targets)
 - #146064 (Add compiler error when trying to use concat metavar expr in repetitions)
 - #146070 (rustdoc-search: skip loading unneeded fnData)
 - #146088 (constify impl Try for ControlFlow)
 - #146089 (fix a constness ordering bug in rustfmt)
 - #146091 (fix rustdoc `render_call_locations`  panicking because of default span `DUMMY_SP` pointing at non local-source file)
 - #146094 (Make `Parser::parse_for_head` public for rustfmt usage)
 - #146102 (Remove dead code stemming from an old effects desugaring)
 - #146115 (Add maintainer for VxWorks)
 - #146116 (Adjust issue-118306.rs test after LLVM change)
 - #146117 (Fix search index generation)
 - #146118 (improve process::abort rendering in Miri backtraces)

r? `@ghost`
`@rustbot` modify labels: rollup

rust-timer added a commit that referenced this pull request

Sep 2, 2025
Rollup merge of #146089 - npmccallum:rustfmt, r=fmease

fix a constness ordering bug in rustfmt

Normally, changes to rustfmt go into the separate repo. But, in this case, the bug is introduced in a local change and therefore isn't present in the rustfmt repo.

Related to: #146071
Fixes rust-lang/rustfmt#6619.

github-actions bot pushed a commit to rust-lang/miri that referenced this pull request

Sep 3, 2025

rust-cloud-vms bot pushed a commit to makai410/rustc_public that referenced this pull request

Oct 12, 2025

makai410 pushed a commit to makai410/rust that referenced this pull request

Nov 8, 2025
…llaumeGomez

Rollup of 14 pull requests

Successful merges:

 - rust-lang#144066 (stabilize c-style varargs for sysv64, win64, efiapi, aapcs)
 - rust-lang#145783 (add span to struct pattern rest (..))
 - rust-lang#146034 (Update target spec metadata of Arm64EC Windows and Trusty targets)
 - rust-lang#146064 (Add compiler error when trying to use concat metavar expr in repetitions)
 - rust-lang#146070 (rustdoc-search: skip loading unneeded fnData)
 - rust-lang#146088 (constify impl Try for ControlFlow)
 - rust-lang#146089 (fix a constness ordering bug in rustfmt)
 - rust-lang#146091 (fix rustdoc `render_call_locations`  panicking because of default span `DUMMY_SP` pointing at non local-source file)
 - rust-lang#146094 (Make `Parser::parse_for_head` public for rustfmt usage)
 - rust-lang#146102 (Remove dead code stemming from an old effects desugaring)
 - rust-lang#146115 (Add maintainer for VxWorks)
 - rust-lang#146116 (Adjust issue-118306.rs test after LLVM change)
 - rust-lang#146117 (Fix search index generation)
 - rust-lang#146118 (improve process::abort rendering in Miri backtraces)

r? `@ghost`
`@rustbot` modify labels: rollup

makai410 pushed a commit to makai410/rust that referenced this pull request

Nov 10, 2025
fix a constness ordering bug in rustfmt

Normally, changes to rustfmt go into the separate repo. But, in this case, the bug is introduced in a local change and therefore isn't present in the rustfmt repo.

Related to: rust-lang#146071
Fixes rust-lang/rustfmt#6619.

makai410 pushed a commit to makai410/rust that referenced this pull request

Nov 10, 2025
…llaumeGomez

Rollup of 14 pull requests

Successful merges:

 - rust-lang#144066 (stabilize c-style varargs for sysv64, win64, efiapi, aapcs)
 - rust-lang#145783 (add span to struct pattern rest (..))
 - rust-lang#146034 (Update target spec metadata of Arm64EC Windows and Trusty targets)
 - rust-lang#146064 (Add compiler error when trying to use concat metavar expr in repetitions)
 - rust-lang#146070 (rustdoc-search: skip loading unneeded fnData)
 - rust-lang#146088 (constify impl Try for ControlFlow)
 - rust-lang#146089 (fix a constness ordering bug in rustfmt)
 - rust-lang#146091 (fix rustdoc `render_call_locations`  panicking because of default span `DUMMY_SP` pointing at non local-source file)
 - rust-lang#146094 (Make `Parser::parse_for_head` public for rustfmt usage)
 - rust-lang#146102 (Remove dead code stemming from an old effects desugaring)
 - rust-lang#146115 (Add maintainer for VxWorks)
 - rust-lang#146116 (Adjust issue-118306.rs test after LLVM change)
 - rust-lang#146117 (Fix search index generation)
 - rust-lang#146118 (improve process::abort rendering in Miri backtraces)

r? `@ghost`
`@rustbot` modify labels: rollup

makai410 pushed a commit to makai410/rustc_public that referenced this pull request

Nov 16, 2025

rust-bors bot pushed a commit that referenced this pull request

Feb 27, 2026
fix a constness ordering bug in rustfmt

Normally, changes to rustfmt go into the separate repo. But, in this case, the bug is introduced in a local change and therefore isn't present in the rustfmt repo.

Related to: #146071
Fixes rust-lang/rustfmt#6619.