Add a timeout to the `remote-test-client` connection by pvdrz · Pull Request #147952 · rust-lang/rust

jyn514

Enselic

Enselic

Enselic

@rustbot rustbot added S-waiting-on-author

Status: This is awaiting some action (such as code changes or more information) from the author.

and removed S-waiting-on-review

Status: Awaiting review from the assignee but also interested parties.

labels

Oct 30, 2025

@rustbot rustbot added the T-bootstrap

Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)

label

Nov 6, 2025

@pvdrz pvdrz mentioned this pull request

Nov 19, 2025

@pvdrz

Enselic

@pvdrz

@pvdrz

@bors bors added S-waiting-on-bors

Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

and removed S-waiting-on-review

Status: Awaiting review from the assignee but also interested parties.

labels

Nov 28, 2025

bors added a commit that referenced this pull request

Nov 28, 2025
Rollup of 6 pull requests

Successful merges:

 - #147952 (Add a timeout to the `remote-test-client` connection)
 - #149321 (Fix ICE when include_str! reads binary files)
 - #149398 (add regression test for issue #143987)
 - #149411 (Tidying up UI tests [5/N])
 - #149413 (add test for issue 143821)
 - #149415 (Remove test-float-parse from workspace list in tidy)

r? `@ghost`
`@rustbot` modify labels: rollup

bors added a commit that referenced this pull request

Nov 28, 2025
Rollup of 6 pull requests

Successful merges:

 - #147952 (Add a timeout to the `remote-test-client` connection)
 - #149321 (Fix ICE when include_str! reads binary files)
 - #149398 (add regression test for issue #143987)
 - #149411 (Tidying up UI tests [5/N])
 - #149413 (add test for issue 143821)
 - #149415 (Remove test-float-parse from workspace list in tidy)

r? `@ghost`
`@rustbot` modify labels: rollup

rust-timer added a commit that referenced this pull request

Nov 28, 2025
Rollup merge of #147952 - ferrocene:pvdrz/remote-test-client-timeout, r=Enselic

Add a timeout to the `remote-test-client` connection

Currently, the `remote-test-client` doesn't have a timeout when connecting to the `remote-test-server`. This means that running tests using it can hang indefinitely which causes issues when running tests on CI, for example.

This PR now sets a default timeout of 5 minutes, meaning that if, for example, `TEST_DEVICE_ADDR=<IP:PORT> ./x test --target riscv64gc-unknown-linux-gnu tests/ui` is run and the `remote-test-server` is not reachable by the client, the client will panic after the timeout is reached.

Additionally, the `TEST_DEVICE_CONNECT_TIMEOUT` env variable can be used to set up the timeout to any value (in seconds).

This PR also wires up a test step for `remote-test-client`, which didn't previously have tool tests run in CI.

Edit: ~~blocked by #149071~~

@tshepang tshepang deleted the pvdrz/remote-test-client-timeout branch

November 28, 2025 22:54

github-actions bot pushed a commit to rust-lang/miri that referenced this pull request

Nov 29, 2025

github-actions bot pushed a commit to rust-lang/rustc-dev-guide that referenced this pull request

Dec 1, 2025