Add a timeout to the `remote-test-client` connection by pvdrz · Pull Request #147952 · rust-lang/rust
rustbot
added
S-waiting-on-author
and removed S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.labels
Oct 30, 2025
rustbot
added
the
T-bootstrap
label
Nov 6, 2025
pvdrz
mentioned this pull request
bors
added
S-waiting-on-bors
and removed S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.labels
Nov 28, 2025bors added a commit that referenced this pull request
Nov 28, 2025Rollup of 6 pull requests Successful merges: - #147952 (Add a timeout to the `remote-test-client` connection) - #149321 (Fix ICE when include_str! reads binary files) - #149398 (add regression test for issue #143987) - #149411 (Tidying up UI tests [5/N]) - #149413 (add test for issue 143821) - #149415 (Remove test-float-parse from workspace list in tidy) r? `@ghost` `@rustbot` modify labels: rollup
bors added a commit that referenced this pull request
Nov 28, 2025Rollup of 6 pull requests Successful merges: - #147952 (Add a timeout to the `remote-test-client` connection) - #149321 (Fix ICE when include_str! reads binary files) - #149398 (add regression test for issue #143987) - #149411 (Tidying up UI tests [5/N]) - #149413 (add test for issue 143821) - #149415 (Remove test-float-parse from workspace list in tidy) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer added a commit that referenced this pull request
Nov 28, 2025Rollup merge of #147952 - ferrocene:pvdrz/remote-test-client-timeout, r=Enselic Add a timeout to the `remote-test-client` connection Currently, the `remote-test-client` doesn't have a timeout when connecting to the `remote-test-server`. This means that running tests using it can hang indefinitely which causes issues when running tests on CI, for example. This PR now sets a default timeout of 5 minutes, meaning that if, for example, `TEST_DEVICE_ADDR=<IP:PORT> ./x test --target riscv64gc-unknown-linux-gnu tests/ui` is run and the `remote-test-server` is not reachable by the client, the client will panic after the timeout is reached. Additionally, the `TEST_DEVICE_CONNECT_TIMEOUT` env variable can be used to set up the timeout to any value (in seconds). This PR also wires up a test step for `remote-test-client`, which didn't previously have tool tests run in CI. Edit: ~~blocked by #149071~~
tshepang
deleted the
pvdrz/remote-test-client-timeout
branch
github-actions bot pushed a commit to rust-lang/rustc-dev-guide that referenced this pull request
Dec 1, 2025This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters