rustdoc: Rename unstable option `--nocapture` to `--no-capture` in accordance with `libtest` by fmease · Pull Request #148115 · rust-lang/rust

@rustbot added S-waiting-on-author

Status: This is awaiting some action (such as code changes or more information) from the author.

T-rustdoc

Relevant to the rustdoc team, which will review and decide on the PR/issue.

labels

Oct 25, 2025

@fmease

@fmease fmease changed the title rustdoc: Rename unstable option --nocapture to --no-capture rustdoc: Rename unstable option --nocapture to --no-capture in accordance with libtest

Oct 25, 2025

@fmease fmease marked this pull request as ready for review

October 25, 2025 21:15

@rustbot rustbot removed the S-waiting-on-author

Status: This is awaiting some action (such as code changes or more information) from the author.

label

Oct 25, 2025

@bors bors added S-waiting-on-bors

Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

and removed S-waiting-on-review

Status: Awaiting review from the assignee but also interested parties.

labels

Oct 29, 2025

matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request

Oct 29, 2025
…ddle

rustdoc: Rename unstable option `--nocapture` to `--no-capture` in accordance with `libtest`

Context: rust-lang#133073, rust-lang#139224 (TL;DR: `libtest` has soft-deprecated `--nocapture` in favor a new & stable `--no-capture`; we should follow suit).

Since the rustdoc flag is unstable (tracking issue: rust-lang#148116), we're allowed to remove the old flag immediately. However since the flag has existed for 4 years we could hard-deprecate the flag first or at least be considerate and provide a diagnostic referring users to the new flag. This PR does neither. Let me know what you would think would be best.

Cargo doesn't use this flag, not yet at least (rust-lang/cargo#9705), so we really are free to sunset this flag without bigger consequences.

bors added a commit that referenced this pull request

Oct 30, 2025
Rollup of 4 pull requests

Successful merges:

 - #148115 (rustdoc: Rename unstable option `--nocapture` to `--no-capture` in accordance with `libtest`)
 - #148137 (Couple of changes for Redox OS)
 - #148176 ([rustdoc] Include attribute and derive macros when filtering on "macros")
 - #148253 (Handle default features and -Ctarget-features in the dummy backend)

r? `@ghost`
`@rustbot` modify labels: rollup

Zalathar added a commit to Zalathar/rust that referenced this pull request

Oct 30, 2025
…ddle

rustdoc: Rename unstable option `--nocapture` to `--no-capture` in accordance with `libtest`

Context: rust-lang#133073, rust-lang#139224 (TL;DR: `libtest` has soft-deprecated `--nocapture` in favor a new & stable `--no-capture`; we should follow suit).

Since the rustdoc flag is unstable (tracking issue: rust-lang#148116), we're allowed to remove the old flag immediately. However since the flag has existed for 4 years we could hard-deprecate the flag first or at least be considerate and provide a diagnostic referring users to the new flag. This PR does neither. Let me know what you would think would be best.

Cargo doesn't use this flag, not yet at least (rust-lang/cargo#9705), so we really are free to sunset this flag without bigger consequences.

bors added a commit that referenced this pull request

Oct 30, 2025
Rollup of 9 pull requests

Successful merges:

 - #138217 (Turn `Cow::is_borrowed,is_owned` into associated functions.)
 - #147858 (Micro-optimization attempt in coroutine layout computation)
 - #147923 (Simplify rustc_public context handling)
 - #147935 (Add LLVM realtime sanitizer)
 - #148115 (rustdoc: Rename unstable option `--nocapture` to `--no-capture` in accordance with `libtest`)
 - #148137 (Couple of changes for Redox OS)
 - #148176 ([rustdoc] Include attribute and derive macros when filtering on "macros")
 - #148193 (Remove `QPath::LangItem`)
 - #148253 (Handle default features and -Ctarget-features in the dummy backend)

r? `@ghost`
`@rustbot` modify labels: rollup

bors added a commit that referenced this pull request

Oct 30, 2025
Rollup of 8 pull requests

Successful merges:

 - #138217 (Turn `Cow::is_borrowed,is_owned` into associated functions.)
 - #147858 (Micro-optimization attempt in coroutine layout computation)
 - #147923 (Simplify rustc_public context handling)
 - #148115 (rustdoc: Rename unstable option `--nocapture` to `--no-capture` in accordance with `libtest`)
 - #148137 (Couple of changes for Redox OS)
 - #148176 ([rustdoc] Include attribute and derive macros when filtering on "macros")
 - #148253 (Handle default features and -Ctarget-features in the dummy backend)
 - #148272 (Align VEX V5 boot routine to 4 bytes)

r? `@ghost`
`@rustbot` modify labels: rollup

rust-timer added a commit that referenced this pull request

Oct 30, 2025
Rollup merge of #148115 - fmease:rustdoc-no-capture, r=notriddle

rustdoc: Rename unstable option `--nocapture` to `--no-capture` in accordance with `libtest`

Context: #133073, #139224 (TL;DR: `libtest` has soft-deprecated `--nocapture` in favor a new & stable `--no-capture`; we should follow suit).

Since the rustdoc flag is unstable (tracking issue: #148116), we're allowed to remove the old flag immediately. However since the flag has existed for 4 years we could hard-deprecate the flag first or at least be considerate and provide a diagnostic referring users to the new flag. This PR does neither. Let me know what you would think would be best.

Cargo doesn't use this flag, not yet at least (rust-lang/cargo#9705), so we really are free to sunset this flag without bigger consequences.

@fmease fmease deleted the rustdoc-no-capture branch

October 30, 2025 10:04

makai410 pushed a commit to makai410/rustc_public that referenced this pull request

Nov 4, 2025

makai410 pushed a commit to makai410/rust that referenced this pull request

Nov 8, 2025
…ddle

rustdoc: Rename unstable option `--nocapture` to `--no-capture` in accordance with `libtest`

Context: rust-lang#133073, rust-lang#139224 (TL;DR: `libtest` has soft-deprecated `--nocapture` in favor a new & stable `--no-capture`; we should follow suit).

Since the rustdoc flag is unstable (tracking issue: rust-lang#148116), we're allowed to remove the old flag immediately. However since the flag has existed for 4 years we could hard-deprecate the flag first or at least be considerate and provide a diagnostic referring users to the new flag. This PR does neither. Let me know what you would think would be best.

Cargo doesn't use this flag, not yet at least (rust-lang/cargo#9705), so we really are free to sunset this flag without bigger consequences.

makai410 pushed a commit to makai410/rust that referenced this pull request

Nov 8, 2025
Rollup of 8 pull requests

Successful merges:

 - rust-lang#138217 (Turn `Cow::is_borrowed,is_owned` into associated functions.)
 - rust-lang#147858 (Micro-optimization attempt in coroutine layout computation)
 - rust-lang#147923 (Simplify rustc_public context handling)
 - rust-lang#148115 (rustdoc: Rename unstable option `--nocapture` to `--no-capture` in accordance with `libtest`)
 - rust-lang#148137 (Couple of changes for Redox OS)
 - rust-lang#148176 ([rustdoc] Include attribute and derive macros when filtering on "macros")
 - rust-lang#148253 (Handle default features and -Ctarget-features in the dummy backend)
 - rust-lang#148272 (Align VEX V5 boot routine to 4 bytes)

r? `@ghost`
`@rustbot` modify labels: rollup

makai410 pushed a commit to makai410/rust that referenced this pull request

Nov 10, 2025
…ddle

rustdoc: Rename unstable option `--nocapture` to `--no-capture` in accordance with `libtest`

Context: rust-lang#133073, rust-lang#139224 (TL;DR: `libtest` has soft-deprecated `--nocapture` in favor a new & stable `--no-capture`; we should follow suit).

Since the rustdoc flag is unstable (tracking issue: rust-lang#148116), we're allowed to remove the old flag immediately. However since the flag has existed for 4 years we could hard-deprecate the flag first or at least be considerate and provide a diagnostic referring users to the new flag. This PR does neither. Let me know what you would think would be best.

Cargo doesn't use this flag, not yet at least (rust-lang/cargo#9705), so we really are free to sunset this flag without bigger consequences.

makai410 pushed a commit to makai410/rust that referenced this pull request

Nov 10, 2025
Rollup of 8 pull requests

Successful merges:

 - rust-lang#138217 (Turn `Cow::is_borrowed,is_owned` into associated functions.)
 - rust-lang#147858 (Micro-optimization attempt in coroutine layout computation)
 - rust-lang#147923 (Simplify rustc_public context handling)
 - rust-lang#148115 (rustdoc: Rename unstable option `--nocapture` to `--no-capture` in accordance with `libtest`)
 - rust-lang#148137 (Couple of changes for Redox OS)
 - rust-lang#148176 ([rustdoc] Include attribute and derive macros when filtering on "macros")
 - rust-lang#148253 (Handle default features and -Ctarget-features in the dummy backend)
 - rust-lang#148272 (Align VEX V5 boot routine to 4 bytes)

r? `@ghost`
`@rustbot` modify labels: rollup

makai410 pushed a commit to makai410/rustc_public that referenced this pull request

Nov 16, 2025