[rustdoc] Remove `UrlFragment::render` method to unify `clean::types::links` and `anchor` by GuillaumeGomez · Pull Request #149028 · rust-lang/rust

@rustbot rustbot added S-waiting-on-review

Status: Awaiting review from the assignee but also interested parties.

T-rustdoc

Relevant to the rustdoc team, which will review and decide on the PR/issue.

T-rustdoc-frontend

Relevant to the rustdoc-frontend team, which will review and decide on the web UI/UX output.

labels

Nov 17, 2025

lolbinarycat

@GuillaumeGomez

@GuillaumeGomez

lolbinarycat

lolbinarycat

lolbinarycat

@GuillaumeGomez

@bors bors added S-waiting-on-bors

Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

and removed S-waiting-on-review

Status: Awaiting review from the assignee but also interested parties.

labels

Nov 21, 2025

bors added a commit that referenced this pull request

Nov 21, 2025
Rollup of 7 pull requests

Successful merges:

 - #146978 (Emit error when using path-segment keyword as cfg pred)
 - #148719 (Allow unnormalized types in drop elaboration)
 - #148795 (add `rust.rustflags` and per target `rustflags` options to `bootstrap.toml`)
 - #149028 ([rustdoc] Remove `UrlFragment::render` method to unify `clean::types::links` and `anchor`)
 - #149043 ( rustdoc-json: add rlib path to ExternalCrate to enable robust crate resolution)
 - #149098 (Fix error message for calling a non-tuple struct)
 - #149151 (Add test for importing path-segment keyword)

r? `@ghost`
`@rustbot` modify labels: rollup

rust-timer added a commit that referenced this pull request

Nov 21, 2025
Rollup merge of #149028 - GuillaumeGomez:unify-anchor, r=lolbinarycat

[rustdoc] Remove `UrlFragment::render` method to unify `clean::types::links` and `anchor`

Fixes #148648.
First part of #148547.

The last part will be about handle `AssocItemLink` differently (either remove it or change how we do it).

r? `@lolbinarycat`

matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request

Nov 24, 2025
…amofek,lolbinarycat

[rustdoc] Make more functions return `fmt::Result` and reduce number of `.unwrap()` calls

Following our discussion in rust-lang#149028 (comment), this PR makes more function return `fmt::Result`, allowing to use `?` a lot more, and also reducing number of `.unwrap()` calls.

r? `@lolbinarycat`

rust-timer added a commit that referenced this pull request

Nov 24, 2025
Rollup merge of #149208 - GuillaumeGomez:less-unwraps, r=yotamofek,lolbinarycat

[rustdoc] Make more functions return `fmt::Result` and reduce number of `.unwrap()` calls

Following our discussion in #149028 (comment), this PR makes more function return `fmt::Result`, allowing to use `?` a lot more, and also reducing number of `.unwrap()` calls.

r? `@lolbinarycat`

github-actions bot pushed a commit to rust-lang/miri that referenced this pull request

Nov 25, 2025
…lbinarycat

[rustdoc] Make more functions return `fmt::Result` and reduce number of `.unwrap()` calls

Following our discussion in rust-lang/rust#149028 (comment), this PR makes more function return `fmt::Result`, allowing to use `?` a lot more, and also reducing number of `.unwrap()` calls.

r? `@lolbinarycat`