Don't allow subdiagnostic to use variables from their parent by JonathanBrouwer · Pull Request #153190

Don't allow subdiagnostic to use variables from their parent by JonathanBrouwer · Pull Request #153190 · rust-lang/rust

added 2 commits

February 27, 2026 14:41

rustbot added A-query-system

Area: The rustc query system (https://rustc-dev-guide.rust-lang.org/query.html)

A-translation

Area: Translation infrastructure, and migrating existing diagnostics to SessionDiagnostic

S-waiting-on-review

Status: Awaiting review from the assignee but also interested parties.

T-compiler

Relevant to the compiler team, which will review and decide on the PR/issue.

labels

Feb 27, 2026

rust-bors bot added S-waiting-on-bors

Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

and removed S-waiting-on-review

Status: Awaiting review from the assignee but also interested parties.

labels

Feb 27, 2026

JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request

Feb 28, 2026

… r=jdonszelmann

Don't allow subdiagnostic to use variables from their parent

Tangentially related to rust-lang#151366

This is PR 1/2 for structured diagnostics, will do the unstructured ones next. After the second PR I will be able to remove some code that should compensate for this PR being positive.

Regardless of this PR having a positive diff, I feel that subdiagnostics being able to use variables from their parent is very confusing, so this is for the better,.

r? @jdonszelmann

JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request

Feb 28, 2026

… r=jdonszelmann

Don't allow subdiagnostic to use variables from their parent

Tangentially related to rust-lang#151366

This is PR 1/2 for structured diagnostics, will do the unstructured ones next. After the second PR I will be able to remove some code that should compensate for this PR being positive.

Regardless of this PR having a positive diff, I feel that subdiagnostics being able to use variables from their parent is very confusing, so this is for the better,.

r? @jdonszelmann

This was referenced

Feb 28, 2026

rust-bors bot pushed a commit that referenced this pull request

Feb 28, 2026

…uwer

Rollup of 12 pull requests

Successful merges:

 - #153211 (`rust-analyzer` subtree update)
 - #149027 (Improve cross-crate trait impl param mismatch suggestions )
 - #152730 (add field representing types)
 - #153136 (Correctly handle `#[doc(alias = "...")]` attribute on inlined reexports)
 - #152165 (Normalize capture place `ty`s to prevent ICE)
 - #152615 (refactor 'valid for read/write' definition: exclude null)
 - #153109 (Fix LegacyKeyValueFormat report from docker build: aarch64-gnu-debug)
 - #153172 (Fix comment about placeholders)
 - #153187 (Fix ICE when macro-expanded extern crate shadows std)
 - #153190 (Don't allow subdiagnostic to use variables from their parent)
 - #153200 (Remove redundant clone)
 - #153216 (mark two polonius tests as known-bug)

rust-timer added a commit that referenced this pull request

Feb 28, 2026

Rollup merge of #153190 - JonathanBrouwer:subdiag_variables, r=jdonszelmann

Don't allow subdiagnostic to use variables from their parent

Tangentially related to #151366

This is PR 1/2 for structured diagnostics, will do the unstructured ones next. After the second PR I will be able to remove some code that should compensate for this PR being positive.

Regardless of this PR having a positive diff, I feel that subdiagnostics being able to use variables from their parent is very confusing, so this is for the better,.

r? @jdonszelmann

github-actions bot pushed a commit to rust-lang/rust-analyzer that referenced this pull request

Mar 2, 2026