Support "soft" feature-gating using a lint by petrochenkov · Pull Request #64066

Support "soft" feature-gating using a lint by petrochenkov · Pull Request #64066 · rust-lang/rust

Relevant to the compiler team, which will review and decide on the PR/issue.

label

Sep 5, 2019

Use it for feature-gating `#[bench]`

bors added S-waiting-on-bors

Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

and removed S-waiting-on-author

Status: This is awaiting some action (such as code changes or more information) from the author.

labels

Sep 7, 2019

Centril added a commit to Centril/rust that referenced this pull request

Sep 7, 2019

Support "soft" feature-gating using a lint

Use it for feature-gating `#[bench]`.

Closes rust-lang#63798.

bors added a commit that referenced this pull request

Sep 7, 2019

Rollup of 5 pull requests

Successful merges:

 - #64052 (Rename test locals to work around LLDB bug)
 - #64066 (Support "soft" feature-gating using a lint)
 - #64177 (resolve: Do not afraid to set current module to enums and traits)
 - #64229 (Reduce span to function name in unreachable calls)
 - #64255 (Add methods for converting `bool` to `Option<T>`)

Failed merges:

r? @ghost

bors added a commit that referenced this pull request

Sep 14, 2019

[beta] Rollup backports

Cherry-picked:

- Permit unwinding through FFI by default #62603
- pprust: Do not print spaces before some tokens #63897
- Account for doc comments coming from proc macros without spans #63930
- Support "soft" feature-gating using a lint #64066
- Update xLTO compatibility table in rustc book. #64092
- Include compiler-rt in the source tarball #64240
- Update LLVM submodule #64317

r? @Mark-Simulacrum

bors added a commit to rust-lang-ci/rust that referenced this pull request

Dec 20, 2024

de-stabilize bench attribute

This has been soft-unstable since forever (rust-lang#64066), and shown in future-compat reports since Rust 1.77 (rust-lang#116274).

The feature covering `bench` itself is tracked in rust-lang#50297, which has been closed despite still having active feature gates referencing it.

Cc `@rust-lang/libs-api`

jhpratt added a commit to jhpratt/rust that referenced this pull request

May 7, 2025

…aheemdev,traviscross

de-stabilize bench attribute

This has been soft-unstable since forever (rust-lang#64066), and shown in future-compat reports since Rust 1.77 (rust-lang#116274).

The feature covering `bench` itself is tracked in rust-lang#50297, which has been closed despite still having active feature gates referencing it.

Cc `@rust-lang/libs-api`

rust-timer added a commit to rust-lang-ci/rust that referenced this pull request

May 7, 2025

Rollup merge of rust-lang#134273 - RalfJung:de-stabilize-bench, r=ibraheemdev,traviscross

de-stabilize bench attribute

This has been soft-unstable since forever (rust-lang#64066), and shown in future-compat reports since Rust 1.77 (rust-lang#116274).

The feature covering `bench` itself is tracked in rust-lang#50297, which has been closed despite still having active feature gates referencing it.

Cc `@rust-lang/libs-api`

github-actions bot pushed a commit to carolynzech/rust that referenced this pull request

May 16, 2025

…aheemdev,traviscross

de-stabilize bench attribute

This has been soft-unstable since forever (rust-lang#64066), and shown in future-compat reports since Rust 1.77 (rust-lang#116274).

The feature covering `bench` itself is tracked in rust-lang#50297, which has been closed despite still having active feature gates referencing it.

Cc `@rust-lang/libs-api`