Home Original page

Change error about unknown attributes to a warning by jyn514 · Pull Request #82702 · rust-lang/rust

@jyn514 added T-rustdoc

Relevant to the rustdoc team, which will review and decide on the PR/issue.

A-diagnostics

Area: Messages for errors, warnings, and lints

labels

Mar 2, 2021

@jyn514 jyn514 added S-waiting-on-author

Status: This is awaiting some action (such as code changes or more information) from the author.

and removed S-waiting-on-review

Status: Awaiting review from the assignee but also interested parties.

labels

Mar 2, 2021

@jyn514 

This prevents breakage across the ecosystem, since the error was just
introduced recently without first having a warning period.

@jyn514 jyn514 changed the title [WIP] Change error about unknown attributes to a warning Change error about unknown attributes to a warning

Mar 3, 2021

@jyn514 jyn514 added S-waiting-on-review

Status: Awaiting review from the assignee but also interested parties.

and removed S-waiting-on-author

Status: This is awaiting some action (such as code changes or more information) from the author.

labels

Mar 3, 2021

@bors bors added S-waiting-on-bors

Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

and removed S-waiting-on-review

Status: Awaiting review from the assignee but also interested parties.

labels

Mar 3, 2021

@jyn514 jyn514 deleted the downgrade-err branch

March 4, 2021 00:28

This was referenced

Mar 4, 2021

GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request

Mar 5, 2021 
… r=Manishearth

Warn on `#![doc(test(...))]` on items other than the crate root and use future incompatible lint

Part of rust-lang#82672.

This PR does multiple things:
 * Create a new `INVALID_DOC_ATTRIBUTE` lint which is also "future incompatible", allowing us to use it as a warning for the moment until it turns (eventually) into a hard error.
 * Use this link when `#![doc(test(...))]` isn't used at the crate level.
 * Make rust-lang#82702 use this new lint as well.

r? `@jyn514`

GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request

Mar 5, 2021 
… r=Manishearth

Warn on `#![doc(test(...))]` on items other than the crate root and use future incompatible lint

Part of rust-lang#82672.

This PR does multiple things:
 * Create a new `INVALID_DOC_ATTRIBUTE` lint which is also "future incompatible", allowing us to use it as a warning for the moment until it turns (eventually) into a hard error.
 * Use this link when `#![doc(test(...))]` isn't used at the crate level.
 * Make rust-lang#82702 use this new lint as well.

r? ``@jyn514``