Remove `NtExpr`. by nnethercote · Pull Request #96724 · rust-lang/rust

Remove `NtExpr`. by nnethercote · Pull Request #96724 · rust-lang/rust

added the T-compiler

Relevant to the compiler team, which will review and decide on the PR/issue.

label

petrochenkov added S-waiting-on-review

Status: Awaiting review from the assignee but also interested parties.

S-waiting-on-author

Status: This is awaiting some action (such as code changes or more information) from the author.

and removed S-waiting-on-author

Status: This is awaiting some action (such as code changes or more information) from the author.

S-waiting-on-review

Status: Awaiting review from the assignee but also interested parties.

labels

doctest failures:
```
proc_macro/struct.Diagnostic.html:14: broken intra-doc link - [<code>Level :: Error</code>]
proc_macro/struct.Diagnostic.html:15: broken intra-doc link - [<code>Level :: Error</code>]
proc_macro/struct.Diagnostic.html:16: broken intra-doc link - [<code>Level :: Warning</code>]
proc_macro/struct.Diagnostic.html:17: broken intra-doc link - [<code>Level :: Warning</code>]
proc_macro/struct.Diagnostic.html:18: broken intra-doc link - [<code>Level :: Note</code>]
proc_macro/struct.Diagnostic.html:19: broken intra-doc link - [<code>Level :: Note</code>]
proc_macro/struct.Diagnostic.html:20: broken intra-doc link - [<code>Level :: Help</code>]
proc_macro/struct.Diagnostic.html:21: broken intra-doc link - [<code>Level :: Help</code>]
checked links in: 3.9s
number of HTML files scanned: 32308
number of HTML redirects found: 10094
number of links checked: 2259114
number of links ignored due to external: 112863
number of links ignored due to exceptions: 19
number of intra doc links ignored: 25
errors found: 8
found some broken links
```

XXX: caused by changes in pretty-printing: `Level::Error` -> `Level :: Error`.

[*] two ui tests temporarily removed, and one unit test has a couple of
failing-to-parse assertions removed.

XXX:
- Some tests have sub-optimal error messages, I want to improve them
- Added a `src` field to `Delimiter::Invisible` which indicates where it
  came from, partly replicates the Nonterminal kind within
  `Interpolated`.
- parse_meta_item_inner required significant changes, it was assuming
  that parse_unsuffixed_lit didn't consume any tokens on failure

bors added a commit to rust-lang-ci/rust that referenced this pull request

…Kind-Interpolated, r=<try>

Remove `Nonterminal` and `TokenKind::Interpolated`

A third attempt at this; the first attempt was rust-lang#96724 and the second was rust-lang#114647.

r? `@ghost`

bors added a commit to rust-lang-ci/rust that referenced this pull request

…Kind-Interpolated, r=<try>

Remove `Nonterminal` and `TokenKind::Interpolated`

A third attempt at this; the first attempt was rust-lang#96724 and the second was rust-lang#114647.

r? `@ghost`

bors added a commit to rust-lang-ci/rust that referenced this pull request

…Kind-Interpolated, r=<try>

Remove `Nonterminal` and `TokenKind::Interpolated`

A third attempt at this; the first attempt was rust-lang#96724 and the second was rust-lang#114647.

r? `@ghost`

bors added a commit to rust-lang-ci/rust that referenced this pull request

…Kind-Interpolated, r=<try>

Remove `Nonterminal` and `TokenKind::Interpolated`

A third attempt at this; the first attempt was rust-lang#96724 and the second was rust-lang#114647.

r? `@ghost`

bors added a commit to rust-lang-ci/rust that referenced this pull request

…Kind-Interpolated, r=<try>

Remove `Nonterminal` and `TokenKind::Interpolated`

A third attempt at this; the first attempt was rust-lang#96724 and the second was rust-lang#114647.

r? `@ghost`

bors added a commit to rust-lang-ci/rust that referenced this pull request

…Kind-Interpolated, r=<try>

Remove `Nonterminal` and `TokenKind::Interpolated`

A third attempt at this; the first attempt was rust-lang#96724 and the second was rust-lang#114647.

r? `@ghost`

bors added a commit to rust-lang-ci/rust that referenced this pull request

…Kind-Interpolated, r=petrochenkov

Remove `Nonterminal` and `TokenKind::Interpolated`

A third attempt at this; the first attempt was rust-lang#96724 and the second was rust-lang#114647.

r? `@ghost`

rust-bors bot pushed a commit that referenced this pull request

…rpolated, r=petrochenkov

Remove `Nonterminal` and `TokenKind::Interpolated`

A third attempt at this; the first attempt was #96724 and the second was #114647.

r? `@ghost`