ty: Use canonical type to access pointee. by emilio · Pull Request #2245 · rust-lang/rust-bindgen

Skip to content

Navigation Menu

Sign in

Appearance settings

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up

Appearance settings

Conversation

@emilio

Copy link

Contributor

@emilio emilio commented

Jul 25, 2022

edited

Loading

Using the canonical type fixes this but changes the output of some tests
(in particular, pointer to typedefs now point to the underlying type).
So do this only in known-bad cases.

Fixes #2244

ojeda and YakoYakoYokuYoku reacted with heart emoji

@emilio emilio force-pushed the pointer-unknown-attr-const branch from a19cd80 to cc94ee1 Compare

July 25, 2022 09:26
Using the canonical type fixes this but changes the output of some tests
(in particular, pointer to typedefs now point to the underlying type).
So do this only in known-bad cases.

Fixes #2244

@emilio emilio force-pushed the pointer-unknown-attr-const branch from cc94ee1 to d3d6a44 Compare

July 25, 2022 09:36

@emilio emilio merged commit ef2ee38 into master

Jul 25, 2022

@emilio emilio deleted the pointer-unknown-attr-const branch

July 25, 2022 10:06

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Attribute btf_type_tag makes constness of pointers disappear

1 participant

@emilio