Fix`unnecessary_safety_comment` does not lint for the first line by profetia · Pull Request #15354 · rust-lang/rust-clippy
Navigation Menu
{{ message }}
rust-lang / rust-clippy Public
- Notifications You must be signed in to change notification settings
- Fork 1.9k
Fixunnecessary_safety_comment does not lint for the first line#15354
Merged
Fixunnecessary_safety_comment does not lint for the first line#15354
flip1995 merged 1 commit intorust-lang:masterfrom
Fixunnecessary_safety_comment does not lint for the first line#15354
flip1995 merged 1 commit intorust-lang:masterfrom
Conversation
Copy link
Member
Copy link
Collaborator
rustbot
commented
Jul 27, 2025
rustbot commented
Jul 27, 2025
rustbot
added
the
S-waiting-on-review
label
Jul 27, 2025
Copy link
Lintcheck changes for f4c6ab0
| Lint | Added | Removed | Changed |
|---|---|---|---|
clippy::unnecessary_safety_comment |
1 | 0 | 0 |
This comment will be updated if you push new changes
profetia
force-pushed
the
issue14553
branch
from
2edabe8 to
084a9ee
Compare
Copy link
Member Author
profetia
commented
Aug 11, 2025
profetia commented
Aug 11, 2025r? clippy
rustbot
assigned
flip1995 and unassigned
blyxyas
flip1995 reviewed Aug 11, 2025
tests/ui-cargo/undocumented_unsafe_blocks/fail/src/main.rs
Show resolved
Hide resolved
tests/ui-cargo/undocumented_unsafe_blocks/fail/src/main.rs Show resolved Hide resolved
profetia
force-pushed
the
issue14553
branch
from
084a9ee to
d25afba
Compare
flip1995 reviewed Aug 13, 2025
clippy_lints/src/undocumented_unsafe_blocks.rs
Outdated
Show resolved
Hide resolved
clippy_lints/src/undocumented_unsafe_blocks.rs Outdated Show resolved Hide resolved
profetia
requested a review
from flip1995
profetia
force-pushed
the
issue14553
branch
from
d25afba to
f4c6ab0
Compare
Copy link
Member
The lintcheck shows a FP after this change. https://docs.rs/ppv-lite86/0.2.17/src/ppv_lite86/lib.rs.html#8
profetia
closed this
profetia
force-pushed
the
issue14553
branch
from
f4c6ab0 to
9a2076e
Compare
rustbot
removed
the
S-waiting-on-review
label
Aug 21, 2025
profetia
reopened this
rustbot
added
the
S-waiting-on-review
label
Aug 21, 2025
Copy link
Member Author
profetia
commented
Aug 21, 2025
profetia commented
Aug 21, 2025I dont think it is caused by this pr. I rolled its back and it still happens (See the lintcheck run)
profetia
force-pushed
the
issue14553
branch
from
834a770 to
f4c6ab0
Compare
Copy link
Member
flip1995
commented
Aug 22, 2025
flip1995 commented
Aug 22, 2025Thanks for testing this
flip1995
added this pull request to the merge queue
rustbot
removed
the
S-waiting-on-review
label
Aug 22, 2025
ojeda
mentioned this pull request
71 tasks
profetia
deleted the
issue14553
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
4 participants