Cross build to sbt 2.0.0-RC6 by eed3si9n · Pull Request #48 · sbt/sbt-javaagent
| val packager19xVersion = "1.9.16" | ||
|
|
||
| val scala212 = "2.12.20" | ||
| val scala3 = "3.7.2" |
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Naive question out of curiosity: we can use Scala 3.7 in the plugin because SBT 2.x itself is in Scala 3.7, right? I ask because I was expecting to see a Scala 3 LTS version (3.3.x) to ensure the plugin can be consumed in various version of SBT 2.x but I guess SBT 2.x (not RC) won't be released until the next LTS anyway?
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sbt 2.x doesn't follow LTS since it on its own isn't a library, and sbt using the latest allows greater flexibility in the plugin ecosystem.
eed3si9n
marked this pull request as ready for review
Some of the failing tests are more to do with sbt 2 rather than the plugin itself, so I've moved them into a different directory so sbt 1.x would test it but not sbt 2.x.
@eed3si9n can you update to latest RC? Thanks!
sbt 2.0.0-RC7 has a known issue, so I used RC6 here.
eed3si9n
changed the title
Cross build to sbt 2.0.0-RC4
Cross build to sbt 2.0.0-RC6
I see pipeline is OK, can we merge it and cut a release?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters