Make compatible with pytest-asyncio by geigerzaehler · Pull Request #278

Make compatible with pytest-asyncio by geigerzaehler · Pull Request #278 · scientific-python/pytest-doctestplus

Merged

bsipocz merged 2 commits intoscientific-python:mainfrom

geigerzaehler:pytest-asyncio-compat

Jan 21, 2025

Merged

Make compatible with pytest-asyncio#278
bsipocz merged 2 commits intoscientific-python:mainfrom
geigerzaehler:pytest-asyncio-compat

Conversation

Copy link Copy Markdown

Contributor

geigerzaehler commented
Jan 19, 2025

pytest-asyncio reads 1 collector.obj during test collection which raises an ImportError for DocTestTextfilePlus. We fix this by aligning that class with pytest’s DoctestTextfile 2 and setting obj to None.

Fixes #256

Make compatible with pytest-asyncio

4fbd0a8

`pytest-asyncio` reads [1] `collector.obj` during test collection which
raises an `ImportError` for `DocTestTextfilePlus`. We fix this by
aligning that class with pytest’s `DoctestTextfile` [2] and setting
`obj` to `None`.

Fixes scientific-python#256

[1]: https://github.com/pytest-dev/pytest-asyncio/blob/eb63d5ad0ca21041726ada3d5c00211d36418a9b/pytest_asyncio/plugin.py#L640
[2]: https://github.com/pytest-dev/pytest/blob/fc56ae365fcdea800f91683186136a8191e22399/src/_pytest/doctest.py#L421

pllim requested a review from bsipocz