Fixed incorrect highlighting of options that were activated, removed and then re-added in "multiple" mode by sustmi · Pull Request #1420 · selectize/selectize.js
Navigation Menu
{{ message }}
selectize / selectize.js Public
- Notifications You must be signed in to change notification settings
- Fork 3.5k
Merged
risadams merged 2 commits intoselectize:masterfrom
Oct 18, 2022Conversation
Copy link Copy Markdown
Contributor
This PR fixes the following issues:
- Reselecting a removed item in a multiple selectbox have 'active' class #1212
- Remove .active class on items when removed with the X from remove_button plugin #1216
The incorrect behavior can be seen in the following screen-capture:
Also, here is a codepen: https://codepen.io/anon/pen/ERENZB .
After this fix, the re-added options are not highlighted anymore.
michael-maltsev pushed a commit to michael-maltsev/selectize.js that referenced this pull request
Aug 28, 2018…and then re-added in "multiple" mode selectize#1420
sustmi
force-pushed
the
fix-removing-active
branch
from
f25fba1 to
7ac5e6f
Compare
…and then re-added in "multiple" mode Fixes issues selectize#1212 and selectize#1216.
sustmi
force-pushed
the
fix-removing-active
branch
from
7ac5e6f to
18809a9
Compare
Copy link Copy Markdown
Contributor Author
sustmi
commented
Nov 12, 2018
sustmi commented
Nov 12, 2018I rebased the code on the current master and resolved the conflicts.
risadams
force-pushed
the
master
branch
from
2b47a72 to
2e42ba4
Compare
Copy link Copy Markdown
Contributor
github-actions
bot
commented
Jan 1, 2021
github-actions bot commented
Jan 1, 2021Stale pull request message
github-actions
bot
added
the
no-pr-activity
label
github-actions
bot
closed this
glenselle
mentioned this pull request
Copy link Copy Markdown
caseyjhol
commented
Dec 7, 2021
caseyjhol commented
Dec 7, 2021@risadams May want to consider merging this?
risadams
reopened this
risadams
added
pending review
and removed no-pr-activity labels
Dec 7, 2021risadams approved these changes Oct 18, 2022
risadams
merged commit
7052506
into
selectize:master
risadams
added
the
hacktoberfest-accepted
label
caseyjhol
mentioned this pull request
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3 participants