fix: Use httpErrorAsException when passed as parameter to SendGridClient constructor by mortenbock · Pull Request #1180 · sendgrid/sendgrid-csharp
Conversation
Fixes
When passing httpErrorAsException as a parameter to the SendGridClient constructor, it was not used for anything. This PR passes the value the the options object created.
Checklist
- I acknowledge that all my contributions will be made under the project's license
- I have made a material change to the repo (functionality, testing, spelling, grammar)
- I have read the Contribution Guidelines and my PR follows them
- I have titled the PR appropriately
- I have updated my branch with the main branch
- I have added tests that prove my fix is effective or that my feature works
- I have added the necessary documentation about the functionality in the appropriate .md file
- I have added inline documentation to the code I modified
mortenbock
changed the title
Use httpErrorAsException when passed as parameter to SendGridClient constructor
fix: Use httpErrorAsException when passed as parameter to SendGridClient constructor
Well that's awkward. Apparently I did not run a compile before pushing. But I think this would result in the same issue as when the optional parameter was added?
I'm not sure what the best approach is here. I could change the order of the optional parameters maybe for the new overload?
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🥇 Thanks for the fix!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters