feat(client): Add generic typing to @sendgrid/client request function by sashko9807 · Pull Request #1399 · sendgrid/sendgrid-nodejs
Navigation Menu
{{ message }}
sendgrid / sendgrid-nodejs Public
- Notifications You must be signed in to change notification settings
- Fork 779
Open
feat(client): Add generic typing to @sendgrid/client request function#1399
sashko9807 wants to merge 1 commit intosendgrid:mainfrom
feat(client): Add generic typing to @sendgrid/client request function#1399
sashko9807 wants to merge 1 commit intosendgrid:mainfrom
Conversation
Copy link Copy Markdown
Fixes
- Made request function generic, so we can get correct response body type definitions.
- Made ClientResponse generic.
- Made ClientRequest generic.
Checklist
- I acknowledge that all my contributions will be made under the project's license
- I have made a material change to the repo (functionality, testing, spelling, grammar)
- I have read the Contribution Guidelines and my PR follows them
- I have titled the PR appropriately
- I have updated my branch with the main branch
- I have added tests that prove my fix is effective or that my feature works
- I have added the necessary documentation about the functionality in the appropriate .md file
- I have added inline documentation to the code I modified
- Made request function generic, so we can get correct response body. - Made ClientResponse generic - Made ClientRequest generic
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment