feat(client): Add generic typing to @sendgrid/client request function by sashko9807 · Pull Request #1399 · sendgrid/sendgrid-nodejs

Skip to content

Navigation Menu

Sign in

Appearance settings

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up

Appearance settings

Conversation

@sashko9807

Copy link Copy Markdown

@sashko9807 sashko9807 commented

May 24, 2024

edited

Loading

Fixes

  • Made request function generic, so we can get correct response body type definitions.
  • Made ClientResponse generic.
  • Made ClientRequest generic.

Checklist

  • I acknowledge that all my contributions will be made under the project's license
  • I have made a material change to the repo (functionality, testing, spelling, grammar)
  • I have read the Contribution Guidelines and my PR follows them
  • I have titled the PR appropriately
  • I have updated my branch with the main branch
  • I have added tests that prove my fix is effective or that my feature works
  • I have added the necessary documentation about the functionality in the appropriate .md file
  • I have added inline documentation to the code I modified
- Made request function generic, so we can get correct response body.
- Made ClientResponse generic
- Made ClientRequest generic

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@sashko9807