Home Original page

fix: Support 204 response in axios by lopenchi · Pull Request #1428 · sendgrid/sendgrid-nodejs

Conversation

@lopenchi

Fixes

Related PR: #1327

fix: Support 204 response in axios

Checklist

  • I acknowledge that all my contributions will be made under the project's license
  • I have made a material change to the repo (functionality, testing, spelling, grammar)
  • I have read the Contribution Guidelines and my PR follows them
  • I have titled the PR appropriately
  • I have updated my branch with the main branch
  • I have added tests that prove my fix is effective or that my feature works
  • I have added the necessary documentation about the functionality in the appropriate .md file
  • I have added inline documentation to the code I modified

If you have questions, please file a support ticket.

@lopenchi lopenchi changed the title Support 204 response in axios fix: Support 204 response in axios

Feb 18, 2025

bnb

bnb

request.method = 'DELETE';
request.url = '/v3/access_settings/whitelist';
xit('should have the correct response code', () => {
it('should have the correct response code', () => {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In all cases, we should probably also add tests for expected failure state since we are now adding that in (anything that's not 200-299), rather than only the success state?