fix: Make various TypeScript request components optional by notheotherben · Pull Request #354 · sendgrid/sendgrid-nodejs
Navigation Menu
{{ message }}
sendgrid / sendgrid-nodejs Public
- Notifications You must be signed in to change notification settings
- Fork 779
Merged
thinkingserious merged 1 commit intosendgrid:masterfrom
Mar 14, 2017Merged
fix: Make various TypeScript request components optional#354
thinkingserious merged 1 commit intosendgrid:masterfrom
fix: Make various TypeScript request components optional#354
thinkingserious merged 1 commit intosendgrid:masterfrom
Conversation
Copy link Copy Markdown
Contributor
notheotherben
commented
Jan 25, 2017
notheotherben
commented
This should address the issues faced in #353 while still ensuring that we accurately cover the type's requirements.
Please let me know if you have any concerns or further requests for this fix.
Regards,
Benjamin
/cc @sheyaweidberg
This should address the issues faced in sendgrid#353 while still ensuring that we accurately cover the type's requirements.
Copy link Copy Markdown
Contributor
thinkingserious
commented
Jan 25, 2017
thinkingserious commented
Jan 25, 2017Hello @spartan563,
Thank you for the PR!
We will be reviewing this PR soon, in the mean time, if you have not, please be sure to sign our CLA so that we can merge your changes. Thanks again!
Team DX
thinkingserious
added
status: code review request
status: cla needed and removed status: cla needed labels
Jan 25, 2017
Copy link Copy Markdown
jpinkster
commented
Feb 4, 2017
jpinkster commented
Feb 4, 2017ETA on merge?
Copy link Copy Markdown
Contributor
thinkingserious
commented
Feb 6, 2017
thinkingserious commented
Feb 6, 2017Hi @jpinkster,
I don't have a good ETA just yet, but I've added your vote to the issue to help it rise in our backlog.
Thanks!
thinkingserious
merged commit
24cd4bf
into
sendgrid:master
Copy link Copy Markdown
jpinkster
commented
Mar 14, 2017
jpinkster commented
Mar 14, 2017🤘🏼
svcprodsec-sendgrid
mentioned this pull request
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3 participants