feat: geolocation setter in sendgrid-python for GDPR compliance by manisha1997 · Pull Request #1073 · sendgrid/sendgrid-python

@manisha1997

feat!: Geolocation setter for GDPR compliance

Checklist

  • I acknowledge that all my contributions will be made under the project's license
  • I have made a material change to the repo (functionality, testing, spelling, grammar)
  • I have read the Contribution Guidelines and my PR follows them
  • I have titled the PR appropriately
  • I have updated my branch with the main branch
  • I have added tests that prove my fix is effective or that my feature works
  • I have added the necessary documentation about the functionality in the appropriate .md file
  • I have added inline documentation to the code I modified

If you have questions, please file a support ticket.

@manisha1997

@manisha1997

shrutiburman

shrutiburman

shrutiburman

shrutiburman

@manisha1997

@manisha1997

@manisha1997

shrutiburman

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@manisha1997

gladysmae08

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR

@manisha1997

@manisha1997

tbischel

tbischel

@tbischel

regarding precedence:
I think if they explicitly call the setters, it makes sense to respect the latest called. I think if they pass region and host in the constructor at the same time, we should throw an error if they conflict.

@manisha1997

Makes sense Tyler, thanks.
Will introduce the changes accordingly.

@manisha1997

@tbischel, we decided to remove region and only have a data residency setter.
We removed the set_host as we don't want to expose the function right now #1073 (comment).
Can you please review the changes

@manisha1997

tbischel

@tbischel

minor nit with the print placement, but other than that LGTM

@manisha1997

@tiwarishubham635

tiwarishubham635

@manisha1997

tbischel

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

This was referenced

Nov 21, 2024