Require Go 1.21+ by scothis · Pull Request #358 · servicebinding/runtime
Navigation Menu
{{ message }}
servicebinding / runtime Public
- Notifications You must be signed in to change notification settings
- Fork 7
Merged
Require Go 1.21+#358
sadlerap merged 1 commit intoservicebinding:mainfrom
Require Go 1.21+#358
sadlerap merged 1 commit intoservicebinding:mainfrom
Conversation
Copy link Copy Markdown
Member
scothis
commented
Oct 25, 2023
scothis
commented
Some of the nested components already internally require go 1.21 and fail when run (e.g. make deploy). We don't actively that that command in CI, so the incompatible component bump slipped through.
Signed-off-by: Scott Andrews <andrewssc@vmware.com>
scothis
requested a review
from a team
sadlerap approved these changes Oct 25, 2023
mamachanko approved these changes Oct 25, 2023
sadlerap
merged commit
f5cee57
into
servicebinding:main
scothis
deleted the
go-1.21
branch
Copy link Copy Markdown
Contributor
mamachanko
commented
Oct 26, 2023
mamachanko commented
Oct 26, 2023I went through my GH notification and read "runtime". My brain went to "reconciler-runtime" and thought "must approve!". 😆 I approve all the runtimes.
Copy link Copy Markdown
Member Author
scothis
commented
Oct 26, 2023
scothis commented
Oct 26, 2023@mamachanko no harm, as long as you reviewed before hitting approve
Copy link Copy Markdown
Contributor
mamachanko
commented
Oct 26, 2023
mamachanko commented
Oct 26, 2023@mamachanko no harm, as long as you reviewed before hitting approve
I did!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
3 participants