Handle targets with path elements by loosebazooka · Pull Request #853 · sigstore/sigstore-java
Navigation Menu
{{ message }}
sigstore / sigstore-java Public
- Notifications You must be signed in to change notification settings
- Fork 26
Merged
Conversation
Copy link
Member
loosebazooka
commented
Nov 18, 2024
loosebazooka
commented
filesystem store stores them down as urlencoded, this mirrors behavior of the go-tuf client
loosebazooka
requested a review
from patflynn
filesystem store stores them down as urlencoded, this mirrors behavior of the go-tuf client Signed-off-by: Appu Goundan <appu@google.com>
loosebazooka
force-pushed
the
fix_tuf_target_paths
branch
from
6570e4a to
fe49ee8
Compare
patflynn approved these changes Nov 20, 2024
Copy link
Collaborator
patflynn
left a comment
patflynn
left a comment
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is there no downloadTarget test case?
Copy link
Member Author
loosebazooka
commented
Nov 20, 2024
loosebazooka commented
Nov 20, 2024that's handled by conformance, but I'll add it in.
loosebazooka
merged commit
ebacd54
into
main
loosebazooka
deleted the
fix_tuf_target_paths
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants