Make token string oidc client available outside of cli by loosebazooka · Pull Request #925 · sigstore/sigstore-java
Navigation Menu
{{ message }}
sigstore / sigstore-java Public
- Notifications You must be signed in to change notification settings
- Fork 26
Merged
Make token string oidc client available outside of cli#925
Make token string oidc client available outside of cli#925
Conversation
Copy link
Member
loosebazooka
commented
Mar 10, 2025
loosebazooka
commented
@vlsi this is step towards making examples work of fork PRs. Once this is in, we need to add an equivalent gradle oidc thing and then inject the token from conformance into it. wdyt?
Signed-off-by: Appu Goundan <appu@google.com>
loosebazooka
requested a review
from vlsi
vlsi approved these changes Mar 11, 2025
vlsi
deleted the
tokenstring
branch
Copy link
Member Author
loosebazooka
commented
Mar 24, 2025
loosebazooka commented
Mar 24, 2025@vlsi can we make this an optional input for sigstore-gradle ? It will help us fix tests on forked requests?
Copy link
Collaborator
vlsi
commented
Mar 24, 2025
vlsi commented
Mar 24, 2025I don't fully get what you mean by "optional input for sigstore-gradle".
Do you mean Gradle should be aware the actual value can differ across executions?
Do you mean sign task gets "up-to-date" no matter what the actual token shows up during execution?
Copy link
Member Author
Sorry, no I mean, in https://github.com/sigstore/sigstore-java/blob/main/sigstore-gradle/sigstore-gradle-sign-base-plugin/src/main/kotlin/dev/sigstore/sign/OidcClientExtension.kt
and then I'll configure it for the examples dir
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants