Prevent UI updates when there is an unresolved recording in progress by myieye · Pull Request #1763 · sillsdev/web-languageforge
Conversation
Fixes #1762
Description
See #1762
Checklist
- I have labeled my PR with: bug, feature, engineering, security fix or testing
- I have performed a self-review of my own code
- I have reviewed the title & description of this PR which I will use as the squashed PR commit message
- I have commented my code, particularly in hard-to-understand areas
- I have enabled auto-merge (optional)
Testing
Testers, use the following instructions against our staging environment. Post your findings as a comment and include any meaningful screenshots, etc.
- Make various changes to entries while recording, while uploading or anywhere in between and make sure the recording never gets lost.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. The bit where we block UI updates if an upload is in progress might in theory have a better solution, but implementing that better solution would involve a LOT more work than it's worth considering that nobody will notice the UI updates being blocked in 99.8% of cases. So let's get this merged.
myieye
deleted the
bug/1762-bug-ui-refreshes-often-cause-audio-loss
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Labels
2 participants