chore: tiny documentation updates and fix docker compose version warning by megahirt · Pull Request #1808 · sillsdev/web-languageforge

Skip to content

Navigation Menu

Sign in

Appearance settings

Conversation

@megahirt

Description

Updates documentation to reflect that we no longer encourage WSL development. Updated references to Node 22 and PHP 7.4

Removed the docker compose version from the yml file because that was causing a warning message.

  • I have labeled my PR with: bug, feature, engineering, security fix or testing
  • I have performed a self-review of my own code
  • I have reviewed the title & description of this PR which I will use as the squashed PR commit message
  • I have commented my code, particularly in hard-to-understand areas
  • I have added tests that prove my fix is effective or that my feature works
  • I have enabled auto-merge (optional)

@megahirt megahirt added the engineering

Tasks which do not directly relate to a user-facing feature or fix

label

May 3, 2024

@github-actions

Unit Test Results

362 tests   362 ✅  13s ⏱️
 37 suites    0 💤
  1 files      0 ❌

Results for commit 0e767e2.

♻️ This comment has been updated with latest results.

rmunn

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

update references to PHP 7.4
remove WSL recommendation in DEVELOPER docs

we run on straight Windows now

@megahirt

bypassed the failing e2e tests on firefox - these are not real failures

Labels

engineering

Tasks which do not directly relate to a user-facing feature or fix

2 participants

@megahirt @rmunn