fix: handle workflow input flag parsing by asraa · Pull Request #379 · slsa-framework/slsa-verifier

Skip to content

Navigation Menu

Sign in

Appearance settings

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up

Appearance settings

Comments

Conversation

@asraa

Copy link

Contributor

@asraa asraa commented

Dec 2, 2022

bug fix: this fixes a nil map entry assignment when creating workflow input flags.

Fixes slsa-framework/slsa-github-generator#1299

Signed-off-by: Asra Ali asraa@google.com

asraa added 2 commits

December 2, 2022 09:35
Signed-off-by: Asra Ali <asraa@google.com>
Signed-off-by: Asra Ali <asraa@google.com>

@asraa

Copy link

Contributor Author

asraa commented

Dec 2, 2022

@laurentsimon I'd need this in the v2.0.1-rc!

@laurentsimon laurentsimon merged commit d50e89b into slsa-framework:main

Dec 2, 2022
Copy link

@sjn sjn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a test review, from someone not involved in the project whatsoever. Please ignore!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@laurentsimon laurentsimon laurentsimon approved these changes

+2 more reviewers

@sjn sjn sjn left review comments

@nehtech9 nehtech9 nehtech9 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[e2e]: generic workflow_dispatch main workflow_inputs slsa3

4 participants

@asraa @sjn @nehtech9 @laurentsimon