go 1.25 + upgrade containers by burmudar · Pull Request #1192 · sourcegraph/src-cli
Navigation Menu
{{ message }}
sourcegraph / src-cli Public
- Notifications You must be signed in to change notification settings
- Fork 68
Merged
Conversation
Copy link Copy Markdown
Contributor
burmudar
commented
Nov 10, 2025
burmudar
commented
- Update to go 1.25
- Use latest contianers
Test plan
docker build . + go build ./cmd/...
burmudar
requested review from
BolajiOlajide and
keegancsmith
burmudar
self-assigned this
burmudar added 3 commits
November 10, 2025 17:07burmudar commented Nov 10, 2025
Copy link Copy Markdown
Contributor Author
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this was done by running golangci-lint migrate
keegancsmith approved these changes Nov 10, 2025
go.mod
Outdated
Show resolved
Hide resolved
Dockerfile
Outdated
Show resolved
Hide resolved
burmudar added 3 commits
November 10, 2025 17:32
Copy link Copy Markdown
Contributor Author
burmudar
commented
Nov 11, 2025
burmudar commented
Nov 11, 2025I will fix the lint issues separately
burmudar
deleted the
wb/go-1-25
branch
| go 1.24 | ||
|
|
||
| toolchain go1.24.1 | ||
| go 1.23.12 |
Copy link Copy Markdown
Member
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
aah we probably wanted to bump the toolchain. But you know what I am being a bit silly. We should be the only people consuming this so lets just use the latest go version?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants