Introduce xclipo to mock lipo by polac24 · Pull Request #188 · spotify/XCRemoteCache
Navigation Menu
{{ message }}
spotify / XCRemoteCache Public
- Notifications You must be signed in to change notification settings
- Fork 52
Merged
polac24 merged 4 commits intospotify:masterfrom
Mar 21, 2023Merged
Introduce xclipo to mock lipo#188
polac24 merged 4 commits intospotify:masterfrom
Introduce xclipo to mock lipo#188
polac24 merged 4 commits intospotify:masterfrom
Conversation
Copy link Copy Markdown
Collaborator
Follow-up to #185:
- Mocks
lipowithxclipothat creates a dynamic fat library. The logic is the same as in thexclibtoolthat just takes any of input files and creates a hard link. - Add E2E test that covers
xcliposcenario. The PR that proves that it covers that - Introduce WatchApp to the Standalone E2E project #189 includes only that E2E tests - ^ E2E test adds a watch extension
WatchExtension, which depends onStaticFrameworkadded in Support universal binary framework #185. To cover both universal binary scenario (static and dynamic), buildingWatchExtensionis enough - Bumps Xcodeproj to support watch extensions (Add support for
ExtensionKitextension product types (new in Xcode 14) tuist/XcodeProj#687)
This PR adds support for dynamic fat archives, reported in #187
Fixes #187
polac24 added 2 commits
March 11, 2023 10:15
polac24
force-pushed
the
bartosz/20230310-lipo
branch
from
df466f8 to
0064335
Compare
polac24 commented Mar 11, 2023
| import Foundation | ||
|
|
||
| enum XCLibtoolCreateUniversalBinaryError: Error { | ||
| enum XCCreateUniversalBinaryError: Error { |
Copy link Copy Markdown
Collaborator Author
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This enum is used by both XCLibtool and XCLipo
polac24
marked this pull request as ready for review
polac24
requested review from
CognitiveDisson,
PatrikBillgren,
acbdev and
aleksandergrzyb
Copy link Copy Markdown
Collaborator Author
polac24
commented
Mar 17, 2023
polac24 commented
Mar 17, 2023acbdev approved these changes Mar 21, 2023
polac24
merged commit
11eabda
into
spotify:master
polac24
deleted the
bartosz/20230310-lipo
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants