Add support for graceful handling missing common sha by polac24 · Pull Request #199 · spotify/XCRemoteCache
Navigation Menu
{{ message }}
spotify / XCRemoteCache Public
- Notifications You must be signed in to change notification settings
- Fork 52
Merged
polac24 merged 3 commits intospotify:masterfrom
Apr 20, 2023Merged
Add support for graceful handling missing common sha#199
polac24 merged 3 commits intospotify:masterfrom
Add support for graceful handling missing common sha#199
polac24 merged 3 commits intospotify:masterfrom
Conversation
Copy link Copy Markdown
Collaborator
polac24
commented
Apr 19, 2023
polac24
commented
Add a parameter gracefully_handle_missing_common_sha (disabled by default) to not fail the preparation step if git cannot find a common sha with the primary branch.
Requested in #190
polac24 added 2 commits
April 18, 2023 19:41
polac24
requested review from
CognitiveDisson,
PatrikBillgren,
acbdev and
aleksandergrzyb
aleksandergrzyb previously approved these changes Apr 19, 2023
README.md
Outdated
Show resolved
Hide resolved
Sources/XCRemoteCache/Config/XCRemoteCacheConfig.swift
Outdated
Show resolved
Hide resolved
Sources/XCRemoteCache/Config/XCRemoteCacheConfig.swift Outdated Show resolved Hide resolved
Co-authored-by: Aleksander Grzyb <aleksander.grzyb@gmail.com>
polac24
dismissed
aleksandergrzyb’s stale review
via
1c67b79
polac24
requested a review
from aleksandergrzyb
aleksandergrzyb approved these changes Apr 20, 2023
polac24
merged commit
352e72f
into
spotify:master
polac24
deleted the
add-graceful-missing-common-sha
branch
canhth
mentioned this pull request
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants