Fixed task hang up in shellInternal due to unread error pipe. by grigorye · Pull Request #230 · spotify/XCRemoteCache
Navigation Menu
{{ message }}
spotify / XCRemoteCache Public
- Notifications You must be signed in to change notification settings
- Fork 52
Merged
polac24 merged 2 commits intospotify:masterfrom
Nov 22, 2023Merged
Conversation
grigorye
marked this pull request as draft
grigorye
force-pushed
the
bug/shell-hangup-due-to-unread-pipe
branch
from
4330b9b to
0290557
Compare
polac24 reviewed Nov 21, 2023
Sources/XCRemoteCache/Shell/Shell.swift
Outdated
Show resolved
Hide resolved
Sources/XCRemoteCache/Shell/Shell.swift Outdated Show resolved Hide resolved
Co-authored-by: Bartosz Polaczyk <polac24@gmail.com>
polac24 approved these changes Nov 22, 2023
Copy link Copy Markdown
Collaborator
polac24
left a comment
polac24
left a comment
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! If you want to land it, make it a PR and we can merge it.
polac24
mentioned this pull request
grigorye
marked this pull request as ready for review
Copy link Copy Markdown
Contributor Author
Looks good! If you want to land it, make it a PR and we can merge it.
Thanks, yeah, fixing this thing may help to avoid encountering the hangup in further iterations, if any.
Copy link Copy Markdown
Collaborator
polac24
commented
Nov 22, 2023
polac24 commented
Nov 22, 2023thanks!
polac24
merged commit
487a58a
into
spotify:master
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants