Home Original page

Fixed Look and feel for snap packages using Env Variables by deepsidhu1313 · Pull Request #2217 · sqlitebrowser/sqlitebrowser

Skip to content

Navigation Menu

Sign in

Appearance settings

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up

Appearance settings

Conversation

@deepsidhu1313

Copy link

Contributor

Fixed Look and feel for snap packages using Env Variables

Thanks to
https://github.com/popey/mgba-snap/pull/5/files

deepsidhu1313 and others added 2 commits

April 25, 2020 18:08
Signed-off-by: Navdeep Singh Sidhu <navdeepsingh.sidhu95@gmail.com>

@deepsidhu1313

Copy link

Contributor Author

@justinclift Please review changes.

@justinclift

Copy link

Member

Apart from that string weirdness, I'm not really sure what else to check. Guess we should merge this and see if things still work? 😄

@deepsidhu1313

Copy link

Contributor Author

deepsidhu1313 commented

Apr 28, 2020

via email

•

edited by justinclift

Loading

that is weird for me as well. i am not fan of yaml files.

@justinclift justinclift merged commit 2bce428 into sqlitebrowser:master

Apr 28, 2020

@justinclift

Copy link

Member

No worries. Just merged it... lets see how it goes. 😄

deepsidhu1313 reacted with thumbs up emoji

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@justinclift justinclift justinclift left review comments

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@deepsidhu1313 @justinclift