settings: Specify a default databrowser font by Coderlane · Pull Request #3348 · sqlitebrowser/sqlitebrowser
Navigation Menu
{{ message }}
sqlitebrowser / sqlitebrowser Public
- Notifications You must be signed in to change notification settings
- Fork 2.3k
Merged
settings: Specify a default databrowser font#3348
justinclift merged 1 commit intosqlitebrowser:masterfrom
Coderlane:fonts
settings: Specify a default databrowser font#3348
justinclift merged 1 commit intosqlitebrowser:masterfrom
Coderlane:fonts
Conversation
Copy link
Contributor
Coderlane
commented
May 17, 2023
Coderlane
commented
This copies the default font from editor/font below for databrowser/font. Leaving this unset causes odd font issues on macOS when the unset value is read back in.
Fixes #3296
This copies the default font from `editor/font` below for `databrowser/font`. Fixes #3296
Copy link
Member
chrisjlocke
commented
May 17, 2023
chrisjlocke commented
May 17, 2023@scottfurry would be interested* in this, to add to his 'fix settings' project... :)
*or not... ;)
Copy link
Contributor
scottfurry
commented
May 17, 2023
scottfurry commented
May 17, 2023@chrisjlocke - I saw the discussion leading up to this. I'm slowly digging out other defaults. The pull seems like a prudent fix. I would recommend proceeding with this effort.
Copy link
Member
justinclift
commented
May 23, 2023
justinclift commented
May 23, 2023Should this be merged (after running CI), or is it still being worked on, or ?
Copy link
Contributor
scottfurry
commented
May 23, 2023
scottfurry commented
May 23, 2023@justinclift - I would recommend merge. It can be pulled out, if necessary, at a later date.
justinclift
merged commit
70e45fb
into
sqlitebrowser:master
Copy link
Member
justinclift
commented
May 23, 2023
justinclift commented
May 23, 2023Cool, done. 😄
scottfurry
mentioned this pull request
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
4 participants