BUILD_VERSION de-duplication by scottfurry · Pull Request #3405 · sqlitebrowser/sqlitebrowser
Navigation Menu
{{ message }}
sqlitebrowser / sqlitebrowser Public
- Notifications You must be signed in to change notification settings
- Fork 2.3k
Merged
BUILD_VERSION de-duplication#3405
justinclift merged 1 commit intosqlitebrowser:masterfrom
scottfurry:BuildVersion
BUILD_VERSION de-duplication#3405
justinclift merged 1 commit intosqlitebrowser:masterfrom
scottfurry:BuildVersion
Conversation
Copy link
Contributor
scottfurry
commented
Jul 13, 2023
scottfurry
commented
CMake process to determine BUILD_VERSION value is made twice in CMakeLists.txt. Duplicated text is removed and step is moved to a more logical placement.
CMake process to determine BUILD_VERSION value is made twice in CMakeLists.txt. Deplicated text is removed and step is moved to a more logical placement. ::w:
Copy link
Member
justinclift
commented
Jul 13, 2023
justinclift commented
Jul 13, 2023Cool, looks good to me. 😄
justinclift
merged commit
5d6ce7f
into
sqlitebrowser:master
Copy link
Contributor Author
scottfurry
commented
Jul 13, 2023
scottfurry commented
Jul 13, 2023Thanks, @justinclift
scottfurry
deleted the
BuildVersion
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants