changed string checking logic

string.length() > 0 to !string.isEmployee

Issue

The code looks good. If you decide to make more updates, consider grouping multiple small changes into a single review. For most, you can get an idea about how to make the change by checking previous pull requests. But certain issues, like refactoring a method to reduce the complexity, will need to be done in a way that does not introduce new problems. The refactoring issues should be handled one at a time.

No formal PR for this one-line simple change.

The code looks good. If you decide to make more updates, consider grouping multiple small changes into a single review. For most, you can get an idea about how to make the change by checking previous pull requests. But certain issues, like refactoring a method to reduce the complexity, will need to be done in a way that does not introduce new problems. The refactoring issues should be handled one at a time.

Roger that..

No formal PR for this one-line simple change.

Just a try since this is my first time...These updates will flow to sonarqube automatically right?

Yes, the sonarqube build occurs when the PR is first posted. You can see the entry above, which was built yesterday.