Fix XMLTest.testIndentComplicatedJsonObjectWithArrayAndWithConfig() for Windows - in the test by mureinik · Pull Request #782 · stleary/JSON-java

@mureinik

XMLTest.testIndentComplicatedJsonObjectWithArrayAndWithConfig fails
when run on Windows due to mismatching linebreaks (that aren't
important for the test's functionality) between the actual and
expected strings.

For the actual strings, linebreaks are canonized to the platform's
native linebreak using `replaceAll("\\n|\\r\\n",
System.getProperty("line.separator")`. However, the expected result is
read from a file, and is left with the linebreaks that were originally
used to create it.

The solution is to perform the same canonization on both strings.

Closes stleary#781

@stleary mentioned this pull request

Oct 5, 2023

@stleary stleary changed the title Fix XMLTest on Windows Fix XMLTest.testIndentComplicatedJsonObjectWithArrayAndWithConfig() for Windows

Oct 5, 2023

johnjaylward

@mureinik

Use the built-in System.lineSeparator() instead of implementing it
ourselves with System.getProperty("line.separator") in order to clean
up the code and make it easier to maintain.

johnjaylward

@stleary stleary changed the title Fix XMLTest.testIndentComplicatedJsonObjectWithArrayAndWithConfig() for Windows Fix XMLTest.testIndentComplicatedJsonObjectWithArrayAndWithConfig() for Windows - in the test

Oct 6, 2023