Fix the declaration of BASE_IMAGE build argument by martin-g · Pull Request #8 · su2code/Docker-Builds
Navigation Menu
{{ message }}
su2code / Docker-Builds Public
- Notifications You must be signed in to change notification settings
- Fork 3
Merged
pcarruscag merged 1 commit intosu2code:masterfrom
martin-g:update-ubuntu-for-cross-build-2
Jul 2, 2022Merged
Fix the declaration of BASE_IMAGE build argument#8
pcarruscag merged 1 commit intosu2code:masterfrom
martin-g:update-ubuntu-for-cross-build-2
Fix the declaration of BASE_IMAGE build argument#8
pcarruscag merged 1 commit intosu2code:masterfrom
martin-g:update-ubuntu-for-cross-build-2
Conversation
Signed-off-by: Martin Tzvetanov Grigorov <mgrigorov@apache.org>
pr-triage
bot
added
the
PR: unreviewed
label
pcarruscag
merged commit
b712109
into
su2code:master
pr-triage
bot
added
PR: merged
and removed
PR: unreviewed
labels
Copy link
Member Author
martin-g
commented
Jul 3, 2022
martin-g commented
Jul 3, 2022Hi @pcarruscag,
It seems the Windows build needs manual steps: https://github.com/su2code/Docker-Builds/tree/master/build_cross#preparing-and-creating-msmpi-package
I won't be able to work on it next week though. I hope the broken release management work flow does not cause you problems!
martin-g
deleted the
update-ubuntu-for-cross-build-2
branch
Copy link
Member Author
martin-g
commented
Jul 11, 2022
martin-g commented
Jul 11, 2022I am going to get the Windows binary from the old Docker image and put it in the build_cross folder.
I hope this is OK legally. At the moment the binary is inside the Docker container. Now it will be also in Git.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment