I am adding regressions for all the convective numerical schemes in NEMO using the implicit solver. All cases run on an inviscid wedge at the moment, but I am happy to make a new folder in the regression.

Related Work

This will allow us to better track our changes and is the start of a more comprehensive set of regression tests for the Nemo solver coming in the future (boundary conditions, etc.)
This directly relates to #1773 to eventually refactor the AUSM schemes.

PR Checklist

• I am submitting my contribution to the develop branch.
• My contribution generates no new compiler warnings (try with --warnlevel=3 when using meson).
• My contribution is commented and consistent with SU2 style (https://su2code.github.io/docs_v7/Style-Guide/).
• I have added a test case that demonstrates my contribution, if necessary.
• [] I have updated appropriate documentation (Tutorials, Docs Page, config_template.cpp), if necessary.

As mentioned, these all use the same geometry, and I happy to discuss inclusion of different test cases.

Also, I noticed that mutation++ does have a regression case, do we not compile M++ for regression builds?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me, definitely important to get test coverage on these schemes!

Sounds like all these tested cases run, do you have a comparison of convergence history? I'd be curious if they have similar performance on this test case, and would be good to confirm correct behavior past 10 iters.

I do not have a good grasp on the performance of each scheme. I fear that may be a much time-intensive task, particularly since these all are implicit at the moment.

I do not have a good grasp on the performance of each scheme. I fear that may be a much time-intensive task, particularly since these all are implicit at the moment.

I'm thinking just run this test case out to convergence for each scheme then comparing convergence histories. That way if any don't converge, we know we're not grandfathering in broken cases/schemes.

Here is a quick summary for the inviscid wedge case using different NEMO schemes. There is clearly work to be done in the convergence/robustness world.
nemo_scheme_regressions.pdf