Consistent python wrapper function names by pcarruscag · Pull Request #1978 · su2code/SU2
Navigation Menu
{{ message }}
- Notifications You must be signed in to change notification settings
- Fork 969
Merged
pcarruscag merged 8 commits intodevelopfrom
Mar 23, 2023Merged
Consistent python wrapper function names#1978
pcarruscag merged 8 commits intodevelopfrom
Consistent python wrapper function names#1978
pcarruscag merged 8 commits intodevelopfrom
Conversation
Copy link
Member
pcarruscag
commented
Mar 21, 2023
pcarruscag
commented
I've tried to follow some convention for naming the functions. We were using "SetMarkerCustomXX" for CHT-type boundary conditions, so I extended that to other applications.
"Custom" means that the values set this way act as boundary conditions. Whereas the other accessors allow manipulating the state (e.g. for initialization) but do not change the final solution.
I also tried to disambiguate the terms for Flow loads of the flow solver vs FEA solver and mesh deformation.
pcarruscag added 6 commits
March 18, 2023 19:08
pcarruscag
added
the
changelog:feature
label
pr-triage
bot
added
the
PR: unreviewed
label
pcarruscag commented Mar 21, 2023
SU2_CFD/include/drivers/CDriver.hpp
Show resolved
Hide resolved
SU2_CFD/include/drivers/CDriver.hpp Show resolved Hide resolved
jtneedels approved these changes Mar 22, 2023
Copy link
Contributor
jtneedels
left a comment
jtneedels
left a comment
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This LGTM.
pr-triage
bot
added
PR: reviewed-approved
and removed
PR: unreviewed
labels
pr-triage
bot
added
PR: unreviewed
and removed
PR: reviewed-approved
labels
WallyMaier approved these changes Mar 23, 2023
pr-triage
bot
added
PR: reviewed-approved
and removed
PR: unreviewed
labels
pcarruscag
merged commit
77fa207
into
develop
pcarruscag
deleted the
consistent_py_wrapper_func_names
branch
pr-triage
bot
added
PR: merged
and removed
PR: reviewed-approved
labels
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment