Fix order of transition volume outputs by pcarruscag · Pull Request #1985 · su2code/SU2
Navigation Menu
{{ message }}
- Notifications You must be signed in to change notification settings
- Fork 966
Merged
Fix order of transition volume outputs#1985
pcarruscag merged 1 commit intodevelopfrom
Fix order of transition volume outputs#1985
pcarruscag merged 1 commit intodevelopfrom
Conversation
Copy link
Member
pcarruscag
commented
Mar 25, 2023
pcarruscag
commented
Keeping the solution group together to avoid issues in restarts
pcarruscag
added
the
changelog:fix
label
pr-triage
bot
added
the
PR: unreviewed
label
Copy link
Contributor
bigfooted
commented
Mar 25, 2023
bigfooted commented
Mar 25, 2023Thanks for this, that is a nice clean up. But why not split ..Misc() into ..Limiter() and ..Primitive() ? In any case LGTM.
bigfooted approved these changes Mar 25, 2023
Copy link
Contributor
bigfooted
left a comment
bigfooted
left a comment
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
pr-triage
bot
added
PR: reviewed-approved
and removed
PR: unreviewed
labels
kursatyurt
mentioned this pull request
5 tasks
Copy link
Member Author
pcarruscag
commented
Mar 26, 2023
pcarruscag commented
Mar 26, 2023The important group to keep together is the solution the rest doesn't really matter.
We should change the restart functions to look for variable names instead of relying on the assumed position.
pcarruscag
merged commit
bf16c20
into
develop
pcarruscag
deleted the
fix_transition_outputs
branch
pr-triage
bot
added
PR: merged
and removed
PR: reviewed-approved
labels
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment