Add new example for adjoint fluid flow with custom mesh deformation, fix CGNS issue with compiler flags by pcarruscag · Pull Request #2059 · su2code/SU2
Navigation Menu
{{ message }}
- Notifications You must be signed in to change notification settings
- Fork 969
Merged
Conversation
Copy link
Member
pcarruscag
commented
Jun 23, 2023
pcarruscag
commented
Proposed Changes
I'm also working on an unsteady version, but there is something wrong with the unsteady adjoint.
Related Work
Fixes #2058
PR Checklist
- I am submitting my contribution to the develop branch.
- My contribution generates no new compiler warnings (try with --warnlevel=3 when using meson).
- My contribution is commented and consistent with SU2 style (https://su2code.github.io/docs_v7/Style-Guide/).
- I have added a test case that demonstrates my contribution, if necessary.
- I have updated appropriate documentation (Tutorials, Docs Page, config_template.cpp), if necessary.
pcarruscag
added
the
changelog:chore
label
github-advanced-security bot found potential problems Jun 23, 2023
TestCases/py_wrapper/wavy_wall/run_steady.py
Fixed
Show fixed
Hide fixed
TestCases/py_wrapper/wavy_wall/run_steady.py Fixed Show fixed Hide fixed
TestCases/py_wrapper/wavy_wall/run_steady.py
Fixed
Show fixed
Hide fixed
TestCases/py_wrapper/wavy_wall/run_steady.py Fixed Show fixed Hide fixed
TestCases/py_wrapper/wavy_wall/run_steady.py
Fixed
Show fixed
Hide fixed
TestCases/py_wrapper/wavy_wall/run_steady.py Fixed Show fixed Hide fixed
pcarruscag commented Jun 23, 2023
TestCases/parallel_regression_AD.py
Outdated
Show resolved
Hide resolved
TestCases/parallel_regression_AD.py Outdated Show resolved Hide resolved
pcarruscag commented Jun 24, 2023
TestCases/py_wrapper/wavy_wall/run_steady.py
Outdated
Show resolved
Hide resolved
TestCases/py_wrapper/wavy_wall/run_steady.py Outdated Show resolved Hide resolved
TestCases/py_wrapper/wavy_wall/run_steady.py
Outdated
Show resolved
Hide resolved
TestCases/py_wrapper/wavy_wall/run_steady.py Outdated Show resolved Hide resolved
TestCases/py_wrapper/wavy_wall/run_steady.py
Outdated
Show resolved
Hide resolved
TestCases/py_wrapper/wavy_wall/run_steady.py Outdated Show resolved Hide resolved
.github/workflows/regression.yml
Outdated
Show resolved
Hide resolved
.github/workflows/regression.yml Outdated Show resolved Hide resolved
pcarruscag
merged commit
0fc0d07
into
develop
pcarruscag
deleted the
py_wrapper_example
branch
Copy link
Member Author
pcarruscag
commented
Jun 26, 2023
pcarruscag commented
Jun 26, 2023For completeness, unsteady adjoints do not work for this type of case due to a dependence of the solution on old coordinates (to compute grid velocities) and old volumes (for the dual time derivative) which we do not handle correctly.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment